Skip to content

Conversation

@mahn00b
Copy link

@mahn00b mahn00b commented Mar 31, 2025

A solve for #2720.

A number of people have been complaining about issues related to the navigation, specifically in react 19.

After doing some digging, I realize the issue revolves around the usage of another dependency from @jquense called @jquense/uncontrollable.

In that version of the library, the helper function designed to wrap class components is usingReact.forwardRef. Since it's been deprecated in React 19, I've opted to use the hook implementation.

This PR is just demonstrative. I suggest we refactor the Calendar class component to be a functional component to be able to use the hook implementation of @jquense/uncontrollable.

Temporary Solution:

  • Wrap Calendar in a functional component to utilize the more modern hook implementation included by the library.

Proposed Solution:

  • Refactor Calendar to a functional component
  • Use hook implementation of @jquense/uncontrollable

@cutterbl
Copy link
Collaborator

cutterbl commented Apr 2, 2025

An initial review of your changes, in Storybook, shows all toolbar navigation now broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants