fix: updated usage of Uncontrollable to fix issues in react 19 #2738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solve for #2720.
A number of people have been complaining about issues related to the navigation, specifically in react 19.
After doing some digging, I realize the issue revolves around the usage of another dependency from @jquense called @jquense/uncontrollable.
In that version of the library, the helper function designed to wrap
class componentsis usingReact.forwardRef. Since it's been deprecated in React 19, I've opted to use the hook implementation.This PR is just demonstrative. I suggest we refactor the
Calendarclass component to be a functional component to be able to use the hook implementation of@jquense/uncontrollable.Temporary Solution:
Proposed Solution:
@jquense/uncontrollable