Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for TypeError: _this.isCollectingLocalStats is not a function (it is undefined) #2490

Closed
wants to merge 2 commits into from

Conversation

Romick2005
Copy link
Contributor

#2489 Move isCollectingLocalStats to the statistics. Mark JitsiMeetJS.isCollectingLocalStats as deprecated with warning to use Statistics.isCollectingLocalStats instead.

…eetJS.isCollectingLocalStats as deprecated with warning to use Statistics.isCollectingLocalStats instead.
@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul
Copy link
Member

saghul commented Mar 26, 2024

Why is this change necessary?

@Romick2005
Copy link
Contributor Author

Why is this change necessary?

In order to fix #2489. Also it helps to organize code in more obvious way as now method that depends on statistics is located directly in Statistics file. Don't you think it will look more as cleaner code and as a bonus without an error?

@saghul
Copy link
Member

saghul commented Mar 26, 2024

No, because on UMD builds Statistics is not exposed, JitsiMeetJS is the only exposed object.

In addition, current working code does not have this problem so I suspect is has to do with the environment perhaps.

@Romick2005
Copy link
Contributor Author

No, because on UMD builds Statistics is not exposed, JitsiMeetJS is the only exposed object.

In addition, current working code does not have this problem so I suspect is has to do with the environment perhaps.

Then we can just remove deprecated warning. And isCollectingLocalStats method would be exposed as before via JitsiMeetJS.isCollectingLocalStats.

Should I remove deprecation warning?

@Romick2005
Copy link
Contributor Author

Done sir. Please review and merge please.

@saghul saghul closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants