TypeError: _this.isCollectingLocalStats is not a function (it is undefined)

[Romick2005]

After jitsiConnectionEstablished I tried to call JitsiMeetJS.createLocalTracks({ devices: ['audio'] });
But got an error: "error": [TypeError: _this.isCollectingLocalStats is not a function (it is undefined)]

I am using latest [email protected]

[damencho]

Can you reproduce the same error on alpha.jitsi.net?

[saghul]

I am using latest [email protected]

Are you using our SDKs or using this library directly?

[Romick2005]

Using raw git code pointing main to the index.js. Directly.

[saghul]

Did you initialize the library by calling JitsiMeetJS.init ?

[Romick2005]

Did you initialize the library by calling JitsiMeetJS.init ?

Yes, sir. Only one time on project initial setup.
lib-jitsi-meet version is git reset --hard 006457f.

JitsiMeetJS.init({
  disableAudioLevels: false,
  useIPv6: false,
  disableThirdPartyRequests: true,
});

[Romick2005]

Can you reproduce the same error on alpha.jitsi.net?

Sorry, but I am not sure how to check it there as I using react-native mobile app together with latest lib-jitsi-meet code.

[damencho]

Can you reproduce the same error on alpha.jitsi.net?

Sorry, but I am not sure how to check it there as I using react-native mobile app together with latest lib-jitsi-meet code.

Yeah, I was wondering how is possible jitsi-meet web and mobile already using this and works without a problem, that's why I was asking about some test and I did not see the react-native line.

[Romick2005]

More info.
It is createLocalTracks from JitsiMeetJS.ts with extra console.log:

This is my code and how it is used:

And this is output from console:

[Romick2005]

PS Could it be related with generator creating some different this for an object call? Because if I use it like regular promise it is working )
Working code sample:

[saghul]

Any chance you are calling that before calling JitsiMeetJS.init?

[Romick2005]

Chances is 0%. It is calling after JitsiMeetJS.init - 100%. And as you can see JitsiMeetJS.isCollectingLocalStats is defined before calling JitsiMeetJS.createLocalTracks inside saga generators:
yield call(JitsiMeetJS.createLocalTracks, { devices: ['audio'] });
where call is from
import { call } from 'redux-saga/effects';
and then error comes:
TypeError: _this.isCollectingLocalStats is not a function (it is undefined)

[saghul]

I wonder if call is changint the this bidning?

[Romick2005]

So it is better to have arrow function or better go with my fix.
Please check it and merge if possible.

Thank you!

[Romick2005]

I wonder if call is changint the this bidning?

I assume yes. It is changing this context. So to be safe, please merge my no context dependent fix )

[saghul]

Sorry, I won't do that. As I said, your fix doesn't work because Staristics is not part of the public API.

That library is monkeying with this because you are not calling the function directly, as you should.

This I see nothing to fix on our end.

Use an arrow function please.

It's likely you'll run into a myriad of problems, even if you sidestepped this one.

[Romick2005]

I think you are wrong here as my fix makes things more clear.

1. You do not have to import whole LocalStatsCollector into JitsiMeetJS just for calling isLocalStatsSupported only one. It is better to have isCollectingLocalStats inside Statistics as it is related to this and it is more proper place for this method and Statistics file already have imported LocalStatsCollector as LocalStatsCollector. So it is double win win.
2. This fix will make method isCollectingLocalStats not dependent on this context as in reality it should not be as have no context base dependency. So having it as static method in Statistics is also win-win.

It is sad that you do not see any improvement in my fix.

PS Can you please ask some alternative opinion on this? Looks like you do not like changes even for good.

[saghul]

I appreciate you trying to fix things here. That's why I'm spending some time trying to show you why this fix is not correct.

This library is used by tons of customers, you can't just decide "this is better" so I'm deprecating the function.

It's a marginal improvement at best, and definitely not worth the churn.

Last, you keep ignoring the fact that Statistics is not exposed to the library consumers in UMD form, which means the non-deprecated API is not even reachable.

[Romick2005]

I think you are wrong again and did not pay attention to my changes. I've removed deprecated warning as you suggested, because it make sense.

So please be more attentive next time.