Skip to content

[JENKINS-76118] Fix toggle collapse race condition in Chrome #11115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 31, 2025
Merged

[JENKINS-76118] Fix toggle collapse race condition in Chrome #11115

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
335ce49
[JENKINS-76118] Fix toggle collapse race condition in Chrome
MinuteHanD Sep 25, 2025
d6b7186
fix: formatting
MinuteHanD Sep 26, 2025
8730588
Update core/src/main/resources/lib/form/link/link.js
timja Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/main/resources/lib/form/link/link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
Behaviour.specify("A.post", "link.post", 0, function (element) {
var pendingHref = element.getAttribute("data-post-href");
if (pendingHref) {
element.setAttribute("href", pendingHref);
element.removeAttribute("data-post-href");
}

element.onclick = function () {
var form = document.createElement("form");
form.setAttribute("method", "POST");
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/lib/hudson/executors.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ THE SOFTWARE.
</j:if>
<st:adjunct includes="lib.form.link.link"/>
<!-- TODO improve l:link so the `a` can be changed to `l:link`. -->
<a class="collapse post" href="${rootURL}/toggleCollapse?paneId=executors"
<a class="collapse post" data-post-href="${rootURL}/toggleCollapse?paneId=executors"
tooltip="${paneIsCollapsed ? '%Expand' : '%Collapse'}" data-tooltip-append-to-parent="true">
<j:set var="svgIconId" value="${paneIsCollapsed ? 'chevron-up' : 'chevron-down'}" />
<l:icon src="symbol-${svgIconId}" />
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/lib/layout/pane.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ THE SOFTWARE.
<j:if test="${attrs.id != null}">
<st:adjunct includes="lib.form.link.link"/>
<!-- TODO improve l:link so the `a` can be changed to `l:link`. -->
<a class="collapse post" href="${rootURL}/toggleCollapse?paneId=${attrs.id}"
<a class="collapse post" data-post-href="${rootURL}/toggleCollapse?paneId=${attrs.id}"
title="${paneIsCollapsed ? '%expand' : '%collapse'}">

<j:set var="svgIconId" value="${paneIsCollapsed ? 'chevron-up' : 'chevron-down'}" />
Expand Down
Loading