Skip to content

Conversation

MinuteHanD
Copy link

This change modifies toggle links to use data-post-href initially instead of href. JavaScript now sets the href only when the POST handler is attached, which prevents 404 errors caused by clicking buttons before scripts are fully loaded. It also resolves a Chrome-specific issue where progressive rendering made buttons clickable too early.

In Chrome, toggle collapse buttons (e.g., "Build Executor Status") can trigger 404 errors when clicked immediately
after page load. This happens because Chrome makes the buttons clickable before JavaScript finishes loading, causing GET requests instead of the required POST requests.

fix: Initially rendering links with data-post-href instead of href, making them non-clickable until JavaScript loads and moves the URL to href while attaching the POST handler. This ensures buttons only become clickable when properly configured for POST requests.

Eliminates 404 errors

See JENKINS-76118.

Testing done

Proposed changelog entries

  • human-readable text

Proposed changelog category

/label

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

This change modifies toggle links to use data-post-href initially instead of href. JavaScript now sets the href only when the POST handler is attached, which prevents 404 errors caused by clicking buttons before scripts are fully loaded. It also resolves a Chrome-specific issue where progressive rendering made buttons clickable too early. In addition, comprehensive test documentation and an automated browser test script have been added to verify the fix and provide reproduction steps.

Files updated include enhancements to link.js for data-post-href, updates to pane.jelly and executors.jelly to use the new attribute.
@comment-ops-bot comment-ops-bot bot added the bug For changelog: Minor bug. Will be listed after features label Sep 26, 2025
@MinuteHanD MinuteHanD marked this pull request as ready for review September 26, 2025 06:23
@MinuteHanD MinuteHanD marked this pull request as draft September 26, 2025 06:29
@MinuteHanD MinuteHanD force-pushed the fix/jenkins-76118-toggle-collapse-race-condition branch from db2fe0e to d6b7186 Compare September 26, 2025 06:46
@MinuteHanD MinuteHanD marked this pull request as ready for review September 26, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant