Skip to content

Webpack 5 support #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Webpack 5 support #66

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf06c26
feat: webpack 5 upgrade
Dec 29, 2021
4248afb
feat: webpack 5 upgrade - module import consolidation
Dec 30, 2021
eb606ec
fix: update code based on the package version
tamara027 Mar 12, 2022
5b82d76
feat: change the path for the generated svg
tamara027 Mar 14, 2022
9667d59
fix: revert prevoius change
tamara027 Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/postcss-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ function replaceIconFontDeclarations (fontName, postCssRoot, svgPaths) {
*/
function addFontDeclaration (fontName, postCssRoot, enforcedSvgHeight, svgPaths) {
// The options are passed as a query string so we use the relative svg paths to reduce the path length per file
const options = { svgs: svgPaths.relative, name: fontName, enforcedSvgHeight: enforcedSvgHeight };
const options = { svgs: svgPaths.resolved, name: fontName, enforcedSvgHeight: enforcedSvgHeight };
Copy link
Owner

@jantimon jantimon Mar 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use only relative paths here.. otherwise webpack won't be able to share caches

// Resolve the icon font plugin directoy in case the iconfont-webpack-plugin is used as a sub dependency
const iconFontPluginDirectory = path.dirname(require.resolve('../'));
// Use paths always with slash also for win32 to prevent an issues with resolving the placeholder on windows
Expand Down