Webpack 5 support #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantimon
reviewed
Mar 14, 2022
lib/postcss-plugin.js
Outdated
| function addFontDeclaration (fontName, postCssRoot, enforcedSvgHeight, svgPaths) { | ||
| // The options are passed as a query string so we use the relative svg paths to reduce the path length per file | ||
| const options = { svgs: svgPaths.relative, name: fontName, enforcedSvgHeight: enforcedSvgHeight }; | ||
| const options = { svgs: svgPaths.resolved, name: fontName, enforcedSvgHeight: enforcedSvgHeight }; |
Owner
There was a problem hiding this comment.
we should use only relative paths here.. otherwise webpack won't be able to share caches
|
Is there any update on this @tamara027 / @jantimon ? This looks like the thing we need? |
|
I managed (by trial and error) to make it work in webpack 5.87.0 by removing double quotes on this line: const url = 'data:application/x-font-woff;charset=utf-8;base64,' + result;I'm not an expert in webpack, not sure if this is conceptually correct (and why it works 😀). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.