Skip to content

[Bug]: filter by tags not works in Jaeger-UI #7696 #7717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chinmay3012 wants to merge 5 commits into from
Closed

[Bug]: filter by tags not works in Jaeger-UI #7696 #7717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06389b5
Fix: Remove tool installation from Go Tip workflow
Dec 8, 2025
cea0a12
Fix: Support filtering by otel.status_code=ERROR in Jaeger UI
Dec 8, 2025
e174fa5
Fix filtering by otel.status_code in Jaeger UI
Dec 8, 2025
9d2f487
Make otel.status_code check case-insensitive
Dec 9, 2025
79dc287
Merge branch 'main' into #7696
chinmay3012 Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cmd/query/app/query_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
"github.com/jaegertracing/jaeger/internal/proto-gen/api_v2/metrics"
"github.com/jaegertracing/jaeger/internal/storage/v1/api/metricstore"
"github.com/jaegertracing/jaeger/internal/storage/v1/api/spanstore"
"github.com/jaegertracing/jaeger/internal/telemetry/otelsemconv"
)

const (
Expand Down Expand Up @@ -134,6 +135,12 @@ func (p *queryParser) parseTraceQueryParams(r *http.Request) (*traceQueryParamet
return nil, err
}

if val, ok := tags[otelsemconv.OtelStatusCode]; ok {
if strings.EqualFold(val, "ERROR") {
tags["error"] = "true"
}
Copy link
Member

@yurishkuro yurishkuro Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if user explicitly types otel.status_code:OK? You'd still return spans with errors?

}

limitParam := r.FormValue(limitParam)
limit := defaultQueryLimit
if limitParam != "" {
Expand Down
45 changes: 45 additions & 0 deletions cmd/query/app/query_parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,51 @@ func TestParseTraceQuery(t *testing.T) {
},
},
},
{
"x?service=service&start=0&end=0&operation=operation&limit=200&tag=otel.status_code:ERROR", noErr,
&traceQueryParameters{
TraceQueryParameters: querysvc.TraceQueryParameters{
TraceQueryParameters: spanstore.TraceQueryParameters{
ServiceName: "service",
OperationName: "operation",
StartTimeMin: time.Unix(0, 0),
StartTimeMax: time.Unix(0, 0),
NumTraces: 200,
Tags: map[string]string{"error": "true", "otel.status_code": "ERROR"},
},
},
},
},
{
"x?service=service&start=0&end=0&operation=operation&limit=200&tag=otel.status_code:Error", noErr,
&traceQueryParameters{
TraceQueryParameters: querysvc.TraceQueryParameters{
TraceQueryParameters: spanstore.TraceQueryParameters{
ServiceName: "service",
OperationName: "operation",
StartTimeMin: time.Unix(0, 0),
StartTimeMax: time.Unix(0, 0),
NumTraces: 200,
Tags: map[string]string{"error": "true", "otel.status_code": "Error"},
},
},
},
},
{
"x?service=service&start=0&end=0&operation=operation&limit=200&tag=otel.status_code:OK", noErr,
&traceQueryParameters{
TraceQueryParameters: querysvc.TraceQueryParameters{
TraceQueryParameters: spanstore.TraceQueryParameters{
ServiceName: "service",
OperationName: "operation",
StartTimeMin: time.Unix(0, 0),
StartTimeMax: time.Unix(0, 0),
NumTraces: 200,
Tags: map[string]string{"otel.status_code": "OK"},
},
},
},
},
// tags=JSON with a non-string value 123
{`x?service=service&start=0&end=0&operation=operation&limit=200&tag=k:v&tags={"x":123}`, "malformed 'tags' parameter, cannot unmarshal JSON: json: cannot unmarshal number into Go value of type string", nil},
// tags=JSON
Expand Down
Loading