[Bug]: filter by tags not works in Jaeger-UI #7696 #7717

chinmay3012 · 2025-12-08T20:37:18Z

Which problem is this PR solving?

Resolves [Bug]: filter by tags not works in Jaeger-UI #7696

Description of the changes

Modified the query parser to preserve the otel.status_code tag in trace query parameters instead of deleting it.
Previously, the parser correctly injected error=true when otel.status_code=ERROR, but it removed the original otel.status_code tag. This logic prevented users from filtering by other status codes (e.g., OK) or relying on the storage backend to handle otel.status_code directly.
This change ensures that otel.status_code is passed through to the backend, enabling precise filtering while maintaining backward compatibility for the error=true mapping.

How was this change tested?

Updated unit tests in
cmd/query/app/query_parser_test.go
to verify that otel.status_code is present in the
Tags
map for both ERROR and OK values.
Validated that otel.status_code=ERROR still triggers the addition of error=true (preserving existing behavior) while keeping the original tag.

Signed-off-by: Chinmay Mehrotra <[email protected]>

Preserve the otel.status_code tag in query parameters instead of deleting it. This allows filtering by specific status codes (e.g., OK) while maintaining backward compatibility for implicit error=true mapping. Signed-off-by: Chinmay Mehrotra <[email protected]>

codecov · 2025-12-08T20:54:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.63%. Comparing base (b728d61) to head (79dc287).
⚠️ Report is 83 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7717      +/-   ##
==========================================
+ Coverage   95.59%   95.63%   +0.03%     
==========================================
  Files         311      311              
  Lines       15517    15520       +3     
==========================================
+ Hits        14833    14842       +9     
+ Misses        535      531       -4     
+ Partials      149      147       -2

Flag	Coverage Δ
badger_v1	`9.89% <ø> (ø)`
badger_v2	`2.07% <ø> (ø)`
cassandra-4.x-v1-manual	`14.07% <ø> (ø)`
cassandra-4.x-v2-auto	`2.05% <ø> (ø)`
cassandra-4.x-v2-manual	`2.05% <ø> (ø)`
cassandra-5.x-v1-manual	`14.07% <ø> (ø)`
cassandra-5.x-v2-auto	`2.05% <ø> (ø)`
cassandra-5.x-v2-manual	`2.05% <ø> (ø)`
clickhouse	`1.98% <ø> (ø)`
elasticsearch-6.x-v1	`18.78% <ø> (ø)`
elasticsearch-7.x-v1	`18.82% <ø> (?)`
elasticsearch-8.x-v1	`18.98% <ø> (ø)`
elasticsearch-8.x-v2	`2.07% <ø> (ø)`
elasticsearch-9.x-v2	`2.07% <ø> (?)`
grpc_v1	`9.68% <ø> (ø)`
grpc_v2	`2.07% <ø> (ø)`
kafka-3.x-v2	`2.07% <ø> (ø)`
memory_v2	`2.07% <ø> (ø)`
opensearch-1.x-v1	`18.87% <ø> (ø)`
opensearch-2.x-v1	`18.87% <ø> (ø)`
opensearch-2.x-v2	`2.07% <ø> (ø)`
opensearch-3.x-v2	`2.07% <ø> (ø)`
query	`2.07% <ø> (ø)`
tailsampling-processor	`0.59% <ø> (ø)`
unittests	`94.20% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-12-08T20:55:58Z

Metrics Comparison Summary

Total changes across all snapshots: 53

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 0 metrics
❌ Removed: 53 metrics
🔄 Modified: 0 metrics

❌ Removed Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

➡️ View full metrics file

chinmay3012 · 2025-12-08T21:07:25Z

I wanted to share a quick update : I've been diving deeper into the jaeger codebase and have successfully addressed a few key issues:

Fixed UI Filtering Bug (PR [Bug]: filter by tags not works in Jaeger-UI #7696 #7717): I diagnosed and fixed the issue where filtering by otel.status_code was failing.
Technical Detail: The query parser was deleting the tag after processing ERROR status. I modified the logic to preserve the otel.status_code tag in the query parameters, enabling correct filtering for all status codes (like OK) while maintaining backward compatibility for error=true.
I also added comprehensive unit tests to cover these edge cases.
CI/CD Maintenance: I noticed the
ci-unit-tests-go-tip.yml
workflow was failing due to missing tools.
I fixed the environment setup to ensure unit tests run correctly on the latest Go versions, helping maintain build stability.
I have ensured all my commits are DCO signed and compliant with the contribution guidelines. I am enjoying working with the Jaeger architecture and am eager to tackle more complex challenges for the GSoC project.

yurishkuro · 2025-12-08T23:35:07Z

cmd/query/app/query_parser.go

 	}

+	if val, ok := tags[otelsemconv.OtelStatusCode]; ok {
+		if val == "ERROR" {


we should make it case insensitive

yurishkuro · 2025-12-08T23:36:17Z

cmd/query/app/query_parser.go

+	if val, ok := tags[otelsemconv.OtelStatusCode]; ok {
+		if val == "ERROR" {
+			tags["error"] = "true"
+		}


what happens if user explicitly types otel.status_code:OK? You'd still return spans with errors?

Use strings.EqualFold to handle cases like 'Error' or 'error' correctly. Also added a test case for mixed case input. Signed-off-by: Chinmay Mehrotra <[email protected]>

chinmay3012 · 2025-12-09T05:38:25Z

Thanks for the review! I've updated the PR to handle the status code check case-insensitively as requested.
By preserving the otel.status_code tag in the query parameters (instead of deleting it), we pass it down to the storage backend.
If the user queries otel.status_code=OK, this tag is sent to the backend. Assuming the storage backend indexes and supports filtering by this tag (which the issue implies it should), the query will only return spans matching that specific tag value.
This effectively filters out ERROR spans because they would have otel.status_code=ERROR, which doesn't match OK.
Previously, since the tag was deleted by the parser, the backend received no filter for it, which is why it returned everything (including errors).
This change allows users to filter by any status code supported by the backend, while keeping the existing logic that maps ERROR to error=true for backward compatibility.

yurishkuro · 2026-01-07T18:24:18Z

I believe the original issue has been resolved.

chinmay3012 requested a review from a team as a code owner December 8, 2025 20:37

chinmay3012 requested a review from mahadzaryab1 December 8, 2025 20:37

dosubot bot added the bug label Dec 8, 2025

Chinmay Mehrotra added 3 commits December 9, 2025 02:10

Fix: Remove tool installation from Go Tip workflow

06389b5

Signed-off-by: Chinmay Mehrotra <[email protected]>

Fix: Support filtering by otel.status_code=ERROR in Jaeger UI

cea0a12

Signed-off-by: Chinmay Mehrotra <[email protected]>

chinmay3012 force-pushed the #7696 branch from f955224 to e174fa5 Compare December 8, 2025 20:40

yurishkuro reviewed Dec 8, 2025

View reviewed changes

Make otel.status_code check case-insensitive

9d2f487

Use strings.EqualFold to handle cases like 'Error' or 'error' correctly. Also added a test case for mixed case input. Signed-off-by: Chinmay Mehrotra <[email protected]>

chinmay3012 force-pushed the #7696 branch from 7b806f2 to 9d2f487 Compare December 9, 2025 05:35

Merge branch 'main' into jaegertracing#7696

79dc287

yurishkuro closed this Jan 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Bug]: filter by tags not works in Jaeger-UI #7696 #7717

[Bug]: filter by tags not works in Jaeger-UI #7696 #7717

Uh oh!

chinmay3012 commented Dec 8, 2025 •

edited by yurishkuro

Loading

Uh oh!

codecov bot commented Dec 8, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 8, 2025

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

❌ Removed Metrics

Uh oh!

chinmay3012 commented Dec 8, 2025

Uh oh!

yurishkuro Dec 8, 2025

Uh oh!

yurishkuro Dec 8, 2025

Uh oh!

chinmay3012 commented Dec 9, 2025

Uh oh!

yurishkuro commented Jan 7, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[Bug]: filter by tags not works in Jaeger-UI #7696 #7717

[Bug]: filter by tags not works in Jaeger-UI #7696 #7717

Uh oh!

Conversation

chinmay3012 commented Dec 8, 2025 • edited by yurishkuro Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which problem is this PR solving?

Description of the changes

How was this change tested?

Uh oh!

codecov bot commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 8, 2025

Metrics Comparison Summary

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

❌ Removed Metrics

Uh oh!

chinmay3012 commented Dec 8, 2025

Uh oh!

yurishkuro Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

yurishkuro Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

chinmay3012 commented Dec 9, 2025

Uh oh!

yurishkuro commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chinmay3012 commented Dec 8, 2025 •

edited by yurishkuro

Loading

codecov bot commented Dec 8, 2025 •

edited

Loading

yurishkuro commented Jan 7, 2026 •

edited

Loading