Skip to content

Fix available_filter_functions file path? #5411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix available_filter_functions file path? #5411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/python/bcc/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ def get_kprobe_functions(event_re):
raise e
blacklist = set([])

avail_filter_file = "%s/tracing/available_filter_functions" % DEBUGFS
avail_filter_file = "%s/available_filter_functions" % TRACEFS
Copy link
Collaborator

@chenhengqi chenhengqi Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use os.stat() to check the existence of tracefs/debugfs instead.

Copy link
Author

@iago-lito iago-lito Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test with os.path.exists is already done on line 50 up there. I figured that test covered the check logic and that this line (729) was a wrong application of it?
In any case, I for sure don't understand the thing at play here. Where is available_filter_functions supposed to live? Does it depend on the distro? What are tracefs/debugfs and how are they related?

try:
with open(avail_filter_file, "rb") as avail_filter_f:
avail_filter = set([line.rstrip().split()[0] for line in avail_filter_f])
Expand Down