Fix available_filter_functions file path?
#5411
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to tweak this today to get `offcputime` working.. does it make sense?
iago-lito
requested review from
brendangregg,
chenhengqi,
ekyooo and
yonghong-song
as code owners
|
Possibly related: bpftrace/bpftrace#1338 |
chenhengqi
reviewed
Oct 30, 2025
| blacklist = set([]) | ||
|
|
||
| avail_filter_file = "%s/tracing/available_filter_functions" % DEBUGFS | ||
| avail_filter_file = "%s/available_filter_functions" % TRACEFS |
There was a problem hiding this comment.
Use os.stat() to check the existence of tracefs/debugfs instead.
There was a problem hiding this comment.
A test with os.path.exists is already done on line 50 up there. I figured that test covered the check logic and that this line (729) was a wrong application of it?
In any case, I for sure don't understand the thing at play here. Where is available_filter_functions supposed to live? Does it depend on the distro? What are tracefs/debugfs and how are they related?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to tweak this today to get
offcputimeworking.. does it make sense?