Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

Description of change

The Keystone signing dialog displayed "Confirm Transaction" regardless of whether the user was signing a transaction or a personal message (e.g., dApp login). This PR adds signature type awareness to show the appropriate header.

Changes:

  • Add SignatureType enum (Transaction | Message) to KeystoneProvider.tsx
  • Extend requestSignature to accept optional signatureType parameter (defaults to Transaction)
  • Update ScanBothWays component to render "Confirm Message" or "Confirm Transaction" based on type
  • Update KeystoneSigner to pass SignatureType.Message in signMessage() and SignatureType.Transaction in signTransactionBytes()

Links to any relevant issues

Fixes #6401

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • downloads.sentry-cdn.com
    • Triggering command: /usr/local/bin/node node ./scripts/install.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Wallet: differentiate between transaction and message in KeystoneProvider.tsx</issue_title>
<issue_description>## Description

The header

<Header title="Confirm Transaction" titleCentered onClose={() => onCancel()} />
has Confirm transaction hardcoded, however this component is also used when signing a message (for example to login into a dApp) instead of a transaction. In this case it shouldn't mention transaction

Motivation

Make it clear that a message and not a transaction is signed for the case where it's a message.
</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link

vercel bot commented Nov 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

6 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
apps-ui-kit Ignored Ignored Preview Nov 27, 2025 9:48am
apps-backend Skipped Skipped Nov 27, 2025 9:48am
iota-evm-bridge Skipped Skipped Nov 27, 2025 9:48am
iota-multisig-toolkit Skipped Skipped Nov 27, 2025 9:48am
rebased-explorer Skipped Skipped Nov 27, 2025 9:48am
wallet-dashboard Skipped Skipped Nov 27, 2025 9:48am

@vercel vercel bot temporarily deployed to Preview – rebased-explorer November 27, 2025 08:35 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-ui-kit November 27, 2025 08:35 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard November 27, 2025 08:35 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-multisig-toolkit November 27, 2025 08:35 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge November 27, 2025 08:35 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend November 27, 2025 08:35 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge November 27, 2025 08:46 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend November 27, 2025 08:46 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer November 27, 2025 08:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard November 27, 2025 08:46 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-multisig-toolkit November 27, 2025 08:46 Inactive
Copilot AI changed the title [WIP] Update KeystoneProvider to differentiate transaction from message Wallet: differentiate between transaction and message in KeystoneProvider.tsx Nov 27, 2025
Copilot finished work on behalf of Thoralf-M November 27, 2025 08:50
Copilot AI requested a review from Thoralf-M November 27, 2025 08:50
@github-actions github-actions bot added the wallet Issues related to the IOTA Wallet label Nov 27, 2025
@Thoralf-M Thoralf-M changed the title Wallet: differentiate between transaction and message in KeystoneProvider.tsx feat(wallet): differentiate between transaction and message in KeystoneProvider.tsx Nov 27, 2025
@Thoralf-M Thoralf-M marked this pull request as ready for review November 27, 2025 09:00
@Thoralf-M Thoralf-M requested a review from a team as a code owner November 27, 2025 09:00
@Thoralf-M Thoralf-M force-pushed the copilot/differentiate-transaction-message branch from 9a9ef29 to a8b318a Compare November 27, 2025 09:41
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard November 27, 2025 09:41 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge November 27, 2025 09:41 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer November 27, 2025 09:41 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend November 27, 2025 09:41 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-multisig-toolkit November 27, 2025 09:41 Inactive
@Thoralf-M Thoralf-M force-pushed the copilot/differentiate-transaction-message branch from a8b318a to dd5614d Compare November 27, 2025 09:47
@vercel vercel bot temporarily deployed to Preview – iota-multisig-toolkit November 27, 2025 09:47 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer November 27, 2025 09:47 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend November 27, 2025 09:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard November 27, 2025 09:47 Inactive
@vercel vercel bot temporarily deployed to Preview – iota-evm-bridge November 27, 2025 09:47 Inactive
Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job @copilot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wallet Issues related to the IOTA Wallet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wallet: differentiate between transaction and message in KeystoneProvider.tsx

3 participants