chore(starfish): Remove TODO comment about joining TransactionDigest with BlockDigest (#9399)

Copilot · piotrm50 · web-flow · commit c45a160ee325 · 2025-11-27T08:29:51.000+01:00
# Description of change Decision made to keep `TransactionDigest` and `BlockDigest` as separate structures rather than merging them. - Removed obsolete TODO comment in `crates/starfish/core/src/block_header.rs` referencing issue #8220 The comment suggested potentially joining the two digest types since they share the same parameters. After evaluation, keeping them separate was deemed the better approach. ## Links to any relevant issues Closes #8220 ## How the change has been tested - [ ] Basic tests (linting, compilation, formatting, unit/integration tests) - [ ] Patch-specific tests (correctness, functionality coverage) - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have checked that new and existing unit tests pass locally with my changes  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Join TransactionDigest with BlockDigest</issue_title> > <issue_description>We might need to join TransactionDigest with BlockDigest since we use the same parameters for both structures. TransactionDigest is used for including a commitment for a transaction data to a block header. This digest is used for BlockDigest computations of BlockHeader does not include explicitly the transaction data. </issue_description> > > <agent_instructions>Let's keep it separate. We need to remove the TODO and a comment.</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@piotrm50</author><body> > Let's keep it separate. We need to remove the TODO and a comment. </body></comment_new> > </comments> > </details> - Fixes #8220  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: piotrm50 <4007944+piotrm50@users.noreply.github.com>
diff --git a/crates/starfish/core/src/block_header.rs b/crates/starfish/core/src/block_header.rs
@@ -430,12 +430,6 @@ impl AsRef<[u8]> for BlockHeaderDigest {
     }
 }
 
-// TODO: https://github.com/iotaledger/iota/issues/8220
-// We might need to join TransactionDigest with BlockDigest since we use
-// the same parameters for both structures. TransactionDigest is used for
-// including a commitment for a transaction data to a block header. This digest
-// is used for BlockDigest computations of BlockHeader does not include
-// explicitly the transaction data.
 #[derive(Clone, Copy, Serialize, Deserialize, Default, PartialEq, Eq, PartialOrd, Ord)]
 pub struct TransactionsCommitment([u8; starfish_config::DIGEST_LENGTH]);
 pub type MerkleProofBytes = Vec<u8>;

Original file line number	Diff line number	Diff line change
`@@ -430,12 +430,6 @@ impl AsRef<[u8]> for BlockHeaderDigest {`
`430`	`430`	`}`
`431`	`431`	`}`
`432`	`432`
`433`		`-// TODO: https://github.com/iotaledger/iota/issues/8220`
`434`		`-// We might need to join TransactionDigest with BlockDigest since we use`
`435`		`-// the same parameters for both structures. TransactionDigest is used for`
`436`		`-// including a commitment for a transaction data to a block header. This digest`
`437`		`-// is used for BlockDigest computations of BlockHeader does not include`
`438`		`-// explicitly the transaction data.`
`439`	`433`	`#[derive(Clone, Copy, Serialize, Deserialize, Default, PartialEq, Eq, PartialOrd, Ord)]`
`440`	`434`	`pub struct TransactionsCommitment([u8; starfish_config::DIGEST_LENGTH]);`
`441`	`435`	`pub type MerkleProofBytes = Vec<u8>;`