[DRAFT] Refactor the 2D block load lowering. #4615
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengjunlu
force-pushed
the
chengjun/refactor_block_io_load
branch
from
5ac88f5 to
719c526
Compare
|
Need wait the reland of the block store code in PR#4646 |
chengjunlu
force-pushed
the
chengjun/refactor_block_io_load
branch
from
719c526 to
d725f19
Compare
chengjunlu
commented
Jul 9, 2025
| @@ -1565,9 +1798,15 @@ struct LoadOpToBlockIOConversion | |||
| LogicalResult | |||
| matchAndRewrite(triton::LoadOp op, OpAdaptor adaptor, | |||
| ConversionPatternRewriter &rewriter) const final { | |||
| if (!isLoadCandidate(op)) | |||
| ModuleOp mod = op->getParentOfType<ModuleOp>(); | |||
There was a problem hiding this comment.
Use the common utils.
Signed-off-by: Lu,Chengjun <[email protected]>
Signed-off-by: Lu,Chengjun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: