[MatmulLoopPipeline] Predicate PrefetchOp
#4016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whitney Tsang <[email protected]>
whitneywhtsang
commented
Apr 25, 2025
| @@ -154,7 +155,7 @@ static Value getPredMask(RewriterBase &rewriter, Type typeLike, | |||
| Value currentMask, Value pred) { | |||
| Location loc = pred.getLoc(); | |||
| Value mask = pred; | |||
| Type maskType = tt::getI1SameShape(typeLike); | |||
| Type maskType = tt::getI1SameShape(tt::getPointeeType(typeLike)); | |||
There was a problem hiding this comment.
The type of mask should be getI1SameShape(getPointeeType($_self)) as defined in https://github.com/intel/intel-xpu-backend-for-triton/blob/main/include/triton/Dialect/Triton/IR/TritonOps.td#L233.
There was a problem hiding this comment.
What does typeLike means ? Lets document the parameters this function take and also what it does.
There was a problem hiding this comment.
added function description.
whitneywhtsang
force-pushed
the
whitneywhtsang/prefetch_pipeline
branch
from
3fd9a80 to
6c7a802
Compare
chengjunlu
approved these changes
Apr 25, 2025
etiotto
reviewed
Apr 25, 2025
| @@ -154,7 +155,7 @@ static Value getPredMask(RewriterBase &rewriter, Type typeLike, | |||
| Value currentMask, Value pred) { | |||
| Location loc = pred.getLoc(); | |||
| Value mask = pred; | |||
| Type maskType = tt::getI1SameShape(typeLike); | |||
| Type maskType = tt::getI1SameShape(tt::getPointeeType(typeLike)); | |||
There was a problem hiding this comment.
What does typeLike means ? Lets document the parameters this function take and also what it does.
third_party/intel/lib/TritonIntelGPUTransforms/Pipeliner/MatmulLoopPipeline.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Whitney Tsang <[email protected]>
Signed-off-by: Whitney Tsang <[email protected]>
whitneywhtsang
force-pushed
the
whitneywhtsang/prefetch_pipeline
branch
2 times, most recently
from
88fe8be to
a4b2e2a
Compare
Signed-off-by: Whitney Tsang <[email protected]>
whitneywhtsang
force-pushed
the
whitneywhtsang/prefetch_pipeline
branch
from
a4b2e2a to
cc4150d
Compare
mfrancepillois
approved these changes
Apr 25, 2025
Signed-off-by: Whitney Tsang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
PrefetchOptakesmaskas an argument, we can handle predication ofPrefetchOpinMatmulLoopPipeline.Benchmark CI: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/14657236822 (No performance regressions.)
Note: this change comes partially from #3634.