Skip to content

Consider enable SLPVectorization back #4167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anmyachev opened this issue May 11, 2025 · 4 comments
Open

Consider enable SLPVectorization back #4167

anmyachev opened this issue May 11, 2025 · 4 comments

Comments

@anmyachev
Copy link
Contributor

@anmyachev
Copy link
Contributor Author

anmyachev commented May 11, 2025

The test from the comment now works, but there are other problems: #4166

One example:

****** Running 06-fused-attention test ******

L0 build module failed. Log: 
error: undefined reference to `_Z16__spirv_ocl_fmaxDv32_fS_'
in function: '__spirv_ocl_fmax(float vector[32], float vector[32])' called by kernel: '_attn_fwd'

error: backend compiler failed build.

error: undefined reference to `_Z16__spirv_ocl_exp2Dv32_f'
in function: '__spirv_ocl_exp2(float vector[32])' called by kernel: '_attn_fwd'

error: backend compiler failed build.

Error during Intel loadBinary: Triton Error [ZE]: 0x70000004

@whitneywhtsang WDYT?

@whitneywhtsang
Copy link
Contributor

IGC team suggested to perform vectorization in IGC, and not enable SLPVectorization pass in LLVM opt.

@anmyachev
Copy link
Contributor Author

IGC team suggested to perform vectorization in IGC, and not enable SLPVectorization pass in LLVM opt.

We could at least tell IGC team about new problems we found. I guess it's more common to use library-side vectorization rather than driver-side vectorization? (other developers may face similar problems)

Or is it a problem on our side that we are not taking something into account?

@whitneywhtsang
Copy link
Contributor

Or is it a problem on our side that we are not taking something into account?

Possible, maybe _Z16__spirv_ocl_exp2Dv32_f is not a valid function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants