Fix generation and display of revisions #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This is based on the commits from #108, so will need to be rebased after that's merged. |
neilmayhew
force-pushed
the
fix-revisions
branch
from
bbbc405 to
1a18d2f
Compare
This was referenced Dec 30, 2025
neilmayhew
added a commit
to IntersectMBO/cardano-haskell-packages
that referenced
this pull request
Dec 30, 2025
This brings in the input-output-hk/foliage#109 bug fix and several other improvements
Author
|
These changes mess with the idea of an "immutable", append-only repo because historical revision files will change. However, this has been happening already, because the bug actually causes revision files to be renumbered every time a package is given a new revision. The latest is always numbered |
Author
|
I also noticed (as I was diffing the output before and after my changes) that plutus-core-1.37.0.0 has revisions |
Flake lock file updates:
• Updated input 'flake-utils':
'github:numtide/flake-utils/c1dfcf0' (2024-09-17)
→ 'github:numtide/flake-utils/11707dc' (2024-11-13)
• Updated input 'haskell-nix':
'github:input-output-hk/haskell.nix/a2f75fc' (2024-10-19)
→ 'github:input-output-hk/haskell.nix/cad2645' (2026-01-03)
• Removed input 'haskell-nix/ghc-8.6.5-iohk'
• Updated input 'haskell-nix/hackage':
'github:input-output-hk/hackage.nix/4988994' (2024-10-19)
→ 'github:input-output-hk/hackage.nix/05797dd' (2026-01-03)
• Added input 'haskell-nix/hackage-for-stackage':
'github:input-output-hk/hackage.nix/fba3874' (2026-01-03)
• Added input 'haskell-nix/hackage-internal':
'github:input-output-hk/hackage.nix/f7867ba' (2025-06-19)
• Added input 'haskell-nix/hls':
'github:haskell/haskell-language-server/682d689' (2025-03-10)
• Added input 'haskell-nix/hls-2.10':
'github:haskell/haskell-language-server/2318c61' (2025-03-27)
• Added input 'haskell-nix/hls-2.11':
'github:haskell/haskell-language-server/46ef452' (2025-05-15)
• Updated input 'haskell-nix/hls-2.9':
'github:haskell/haskell-language-server/0c1817c' (2024-07-03)
→ 'github:haskell/haskell-language-server/90319a7' (2024-07-03)
• Removed input 'haskell-nix/hydra'
• Removed input 'haskell-nix/hydra/nix'
• Removed input 'haskell-nix/hydra/nix/lowdown-src'
• Removed input 'haskell-nix/hydra/nix/nixpkgs'
• Removed input 'haskell-nix/hydra/nix/nixpkgs-regression'
• Removed input 'haskell-nix/hydra/nixpkgs'
• Updated input 'haskell-nix/iserv-proxy':
'github:stable-haskell/iserv-proxy/2ed3400' (2024-06-04)
→ 'github:stable-haskell/iserv-proxy/1506051' (2025-08-15)
• Removed input 'haskell-nix/nixpkgs-2003'
• Removed input 'haskell-nix/nixpkgs-2105'
• Removed input 'haskell-nix/nixpkgs-2111'
• Removed input 'haskell-nix/nixpkgs-2205'
• Removed input 'haskell-nix/nixpkgs-2211'
• Updated input 'haskell-nix/nixpkgs-2405':
'github:NixOS/nixpkgs/086b448' (2024-09-16)
→ 'github:NixOS/nixpkgs/1e7a8f3' (2024-12-30)
• Added input 'haskell-nix/nixpkgs-2411':
'github:NixOS/nixpkgs/5ab036a' (2025-06-30)
• Added input 'haskell-nix/nixpkgs-2505':
'github:NixOS/nixpkgs/6c8f0cc' (2025-12-01)
• Added input 'haskell-nix/nixpkgs-2511':
'github:NixOS/nixpkgs/b0924ea' (2025-12-01)
• Updated input 'haskell-nix/nixpkgs-unstable':
'github:NixOS/nixpkgs/658e722' (2024-09-17)
→ 'github:NixOS/nixpkgs/c1cb7d0' (2025-12-01)
• Updated input 'haskell-nix/stackage':
'github:input-output-hk/stackage.nix/df1d8f0' (2024-10-16)
→ 'github:input-output-hk/stackage.nix/8a7333a' (2026-01-03)
neilmayhew
force-pushed
the
fix-revisions
branch
from
1a18d2f to
abf45c0
Compare
Author
|
Rebased on |
neilmayhew
added a commit
to IntersectMBO/cardano-haskell-packages
that referenced
this pull request
Jan 6, 2026
This brings in the input-output-hk/foliage#109 bug fix and several other improvements
neilmayhew
added a commit
to IntersectMBO/cardano-haskell-packages
that referenced
this pull request
Jan 8, 2026
This brings in the input-output-hk/foliage#109 bug fix and several other improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs:
.cabalfiles are numbered in the wrong order (reverse-chronological instead of forward)The 'current'
.cabalfile is correct, which is probably why we haven't noticed this before. However, the incorrect numbering of the individual revisions may have been causing problems with Hydra builds for quite some time: several people have reported that revisions aren't being handled correctly and have assumed that it was the fault of Hydra or Haskell.nix.Edit: This does seem to fix the CHaP build problems on Hydra. It won't be possible to check this on Hydra itself until after this change is merged and the
repobranch is updated. However, testing it with a locally-built_repoand--override-input CHaPenabled a previously-failing nix build to succeed.This PR also improves the display of revisions on the package-version page: it shows the revision number as provided in the
meta.tomlfile, even though in some cases (egplutus-core-1.37.0.0) the numbers aren't sequential.