Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lazy from native and bytecode modes: not thread safe and sometimes SIGSEGV #229

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Remove Lazy from native and bytecode modes: not thread safe and sometimes SIGSEGV #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/angstrom.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,11 +454,14 @@ let take_till f =
let choice ?(failure_msg="no more choices") ps =
List.fold_right (<|>) ps (fail failure_msg)

let notset = { run = fun _buf _pos _more _fail _succ -> failwith "Angstrom.fix_direct not set" }

let fix_direct f =
let rec p = lazy (f r)
let rec p = ref notset
and r = { run = fun buf pos more fail succ ->
(Lazy.force p).run buf pos more fail succ }
(!p).run buf pos more fail succ }
in
p := f r;
r
edwintorok marked this conversation as resolved.
Show resolved Hide resolved

let fix_lazy ~max_steps f =
Expand Down