Update to Dune 3.16, fix build of benchmarks, various fixes #222
Conversation
|
This PR also somewhat supersedes #206, although mine doesn't use Dune to generate the opam files. |
|
Would be good to merge this to fix the CI, as I've just open another PR and ocaml-ci is mostly red there. I"ve done a test on my fork with ocaml-ci and it is a lot greener than master: https://ocaml.ci.dev/github/edwintorok/angstrom/commit/a95f7bced58e57131e4f8161f4b66becd2561393. OTOH the github CI will need to be updated since 4.08 and 4.10 will no longer find a solution: https://github.com/edwintorok/angstrom/actions/runs/10819012123/job/30015924784 (those OCaml versions are very old, that'd be fine). |
MisterDA
changed the title
File "lib_test/test_json.ml", line 9, characters 4-31:
9 | Bigstringaf.blit_from_bytes s ~src_off:0 b ~dst_off:0 ~len:n;
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound value Bigstringaf.blit_from_bytes
They're intended for REPL top-level expressions.
Only test latest OCaml 4 and OCaml 5, the other versions are too old and unsupported.
|
@seliopou I've revisited and rebased this PR, let me know if anything need to be changed. |
Dear maintainer,
This PR updates the build system to depend on Dune 3.16 as it gives many niceties and new warnings. Accordingly, it also fixes the new warnings.
I've also seen that the benchmark wouldn't build so I've updated them for core_unix v0.15.0, and declared their dependencies for testing in the opam files.
Last but not least, angstrom-unix, angstrom-lwt-unix and angstrom-async now depend on the same version of angstrom as they are. Although this could be lifted, I think it greatly simplifies integration and debugging.
Thanks!