Skip to content

fix: prevent dark mode flicker during SPA navigation #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent dark mode flicker during SPA navigation #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/context/ThemeContext.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* eslint-disable react-refresh/only-export-components */
import React, { createContext, useState, useEffect } from "react";
import React, { createContext, useState, useLayoutEffect } from "react";

export const ThemeContext = createContext();

Expand All @@ -13,7 +13,8 @@ export const ThemeProvider = ({ children }) => {
return systemPrefersDark ? "dark" : "light";
});

useEffect(() => {
// Sync theme to DOM synchronously on mount (before paint)
useLayoutEffect(() => {
const root = window.document.documentElement;
if (theme === "dark") {
root.classList.add("dark");
Expand Down
2 changes: 1 addition & 1 deletion src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
@layer base {
body {
font-family: 'Outfit', 'Inter', system-ui, sans-serif;
@apply bg-slate-50 text-slate-800 antialiased transition-colors duration-300;
@apply bg-slate-50 text-slate-800 antialiased;
}

body.dark {
Expand Down
Loading