fix: prevent dark mode flicker during SPA navigation#573
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
- Remove transition-colors from body to prevent visible theme transitions - Use useLayoutEffect instead of useEffect for synchronous DOM updates - Prevents the white flash when navigating between pages in dark mode
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #558
Root cause
The body had
transition-colors duration-300which made color/background changes visible as a 300ms animation. Combined withuseEffect(async, after paint) for theme syncing, this caused a visible white flash during page navigation.Changes
transition-colors duration-300from body — prevents visible color transitions that caused the flashuseEffect→useLayoutEffect— theme class is applied synchronously before browser paintThe blocking script in
index.htmlalready applies the dark class before React mounts; these changes ensure zero flicker during SPA navigation as well.