Feature/alex teleop 2 #1067
Open
Feature/alex teleop 2 #1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (controllerRobotDefinition == null) | ||
| { | ||
| controllerRobotDefinition = getSCS1RobotDefinition(); | ||
| controllerRobotDefinition = getSCS1RobotDefinition(true); |
There was a problem hiding this comment.
should this always be true? shouldn't it be based on the robot version
| getClass().getClassLoader(), | ||
| urdfParameters.getURDFModelName(), | ||
| contactPointParameters, | ||
| createContactPoints ? contactPointParameters : null, |
There was a problem hiding this comment.
why would we need this to be null? why not keep it the old way
…real world testing (#1063) * Settup logging to work on both the high and low level process, fixed a couple of bugs in the starting, and naming of the thing * This shouldn't be a hard coded value, neesds to be the cell size from the parameters * Shrink height map to reduce networking lag * Adjust realsense transform, adjust local logging for testing * Tested more of the logging onboard. Update is either the server, or the intraprocess logger, not both. Optimized the IntraprocessYoVariableLogger so now the longest part is compressing the data before it gets written to disk * Fix gradle deploy, remove link in warning prints * Fix VR finger streaming. --------- Co-authored-by: Alexander OCU <[email protected]> Co-authored-by: VR-OCU <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.