Skip to content

fix: enhance search extensions for user posts data source #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ice-endymion wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: enhance search extensions for user posts data source #3113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fbf3ec
fix: enhance search extensions for user posts data source
ice-endymion Jan 15, 2026
017bbbe
fix: remove unused imports
ice-endymion Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions lib/app/features/feed/providers/user_posts_data_source_provider.r.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// SPDX-License-Identifier: ice License 1.0

import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:ion/app/extensions/extensions.dart';
import 'package:ion/app/features/auth/providers/auth_provider.m.dart';
import 'package:ion/app/features/feed/data/models/entities/article_data.f.dart';
import 'package:ion/app/features/feed/data/models/entities/generic_repost.f.dart';
Expand All @@ -10,8 +9,6 @@ import 'package:ion/app/features/feed/data/models/entities/post_data.f.dart';
import 'package:ion/app/features/feed/data/models/entities/repost_data.f.dart';
import 'package:ion/app/features/ion_connect/ion_connect.dart';
import 'package:ion/app/features/ion_connect/model/action_source.f.dart';
import 'package:ion/app/features/ion_connect/model/related_event.f.dart';
import 'package:ion/app/features/ion_connect/model/related_event_marker.dart';
import 'package:ion/app/features/ion_connect/model/search_extension.dart';
import 'package:ion/app/features/ion_connect/providers/entities_paged_data_provider.m.dart';
import 'package:ion/app/features/tokenized_communities/models/entities/community_token_action.f.dart';
Expand Down Expand Up @@ -65,16 +62,6 @@ List<EntitiesDataSource>? userPostsDataSource(Ref ref, String pubkey) {
...[
for (final kind in withTokensKinds) ...SearchExtensions.withTokens(forKind: kind).extensions,
],
TagMarkerSearchExtension(
Copy link
Contributor

@ice-orion ice-orion Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to fetching the comments, that we don't need on that page, how does it fix the issue?

tagName: RelatedReplaceableEvent.tagName,
marker: RelatedEventMarker.reply.toShortString(),
negative: true,
),
TagMarkerSearchExtension(
tagName: RelatedImmutableEvent.tagName,
marker: RelatedEventMarker.reply.toShortString(),
negative: true,
),
GenericIncludeSearchExtension(
forKind: CommunityTokenActionEntity.kind,
includeKind: CommunityTokenDefinitionEntity.kind,
Expand Down