fix: enhance search extensions for user posts data source #3113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where reposts of comments/replies would disappear from a user's profile after an app restart. The fix removes redundant TagMarkerSearchExtension filters that were incorrectly excluding reposts of replies.
Changes:
- Removed two
TagMarkerSearchExtensioninstances that negatively filtered reply markers from the search query - Relies on existing
entityFilterlogic which properly handles reply exclusion viaparentEvent == nullchecks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ice-endymion
force-pushed
the
fix/repost-comments-persistence
branch
3 times, most recently
from
1f35d73 to
2bd7dca
Compare
ice-morpheus
force-pushed
the
fix/repost-comments-persistence
branch
from
2bd7dca to
b5b2a54
Compare
ice-morpheus
force-pushed
the
fix/repost-comments-persistence
branch
from
b5b2a54 to
017bbbe
Compare
ice-cerberus
approved these changes
Jan 16, 2026
ice-orion
reviewed
Jan 16, 2026
| ...[ | ||
| for (final kind in withTokensKinds) ...SearchExtensions.withTokens(forKind: kind).extensions, | ||
| ], | ||
| TagMarkerSearchExtension( |
Contributor
There was a problem hiding this comment.
This leads to fetching the comments, that we don't need on that page, how does it fix the issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional Notes
Removed the reply marker exclusion from search extensions. The existing
entityFilteralready properly excludes direct replies viaparentEvent == nullcheck, while allowing reposts (which don't haveparentEvent) to pass through.Task ID
ION-4994
Type of Change