-
Notifications
You must be signed in to change notification settings - Fork 12
fix: enhance error handling in token swap and trade community dialogs #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ice-erebus
wants to merge
3
commits into
master
Choose a base branch
from
bugfix/button-error-in-swap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
dcb780f
feat: enhance error handling in token swap and trade community dialogs
ice-erebus 14b3ccf
refactor: replace manual amount validation with useValidateAmount hoo…
ice-erebus b8bfcb6
chore: add SPDX license identifier to use_validate_amount.dart
ice-erebus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
lib/app/features/wallets/views/pages/coins_flow/swap_coins/hooks/use_validate_amount.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| // SPDX-License-Identifier: ice License 1.0 | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
| import 'package:flutter_hooks/flutter_hooks.dart'; | ||
| import 'package:ion/app/extensions/extensions.dart'; | ||
| import 'package:ion/app/features/wallets/model/coin_in_wallet_data.f.dart'; | ||
| import 'package:ion/app/features/wallets/model/coins_group.f.dart'; | ||
| import 'package:ion/app/features/wallets/utils/crypto_amount_converter.dart'; | ||
| import 'package:ion/app/features/wallets/views/utils/amount_parser.dart'; | ||
|
|
||
| void useValidateAmount({ | ||
| required TextEditingController? controller, | ||
| required FocusNode focusNode, | ||
| required CoinInWalletData? coinForNetwork, | ||
| required BuildContext context, | ||
| required ValueChanged<String?>? onValidationError, | ||
| required CoinsGroup? coinsGroup, | ||
| required bool skipValidation, | ||
| }) { | ||
| useEffect( | ||
| () { | ||
| void validateAndNotify() { | ||
| if (onValidationError == null || skipValidation) return; | ||
|
|
||
| final error = _validateAmount( | ||
| controller?.text, | ||
| context, | ||
| coinForNetwork, | ||
| coinsGroup, | ||
| ); | ||
| onValidationError(error); | ||
| } | ||
|
|
||
| void onTextChanged() { | ||
| validateAndNotify(); | ||
| } | ||
|
|
||
| void onFocusChanged() { | ||
| validateAndNotify(); | ||
| } | ||
|
|
||
| controller?.addListener(onTextChanged); | ||
| focusNode.addListener(onFocusChanged); | ||
|
|
||
| // Validate initially | ||
| WidgetsBinding.instance.addPostFrameCallback((_) { | ||
| validateAndNotify(); | ||
| }); | ||
|
|
||
| return () { | ||
| controller?.removeListener(onTextChanged); | ||
| focusNode.removeListener(onFocusChanged); | ||
| }; | ||
| }, | ||
| [ | ||
| controller, | ||
| focusNode, | ||
| coinForNetwork, | ||
| onValidationError, | ||
| coinsGroup, | ||
| ], | ||
| ); | ||
| } | ||
|
|
||
| String? _validateAmount( | ||
| String? value, | ||
| BuildContext context, | ||
| CoinInWalletData? coinForNetwork, | ||
| CoinsGroup? coinsGroup, | ||
| ) { | ||
| final trimmedValue = value?.trim() ?? ''; | ||
| if (trimmedValue.isEmpty) return null; | ||
|
|
||
| final parsed = parseAmount(trimmedValue); | ||
| if (parsed == null) return ''; | ||
|
|
||
| final maxValue = coinForNetwork?.amount; | ||
| if (maxValue != null && (parsed > maxValue || parsed < 0)) { | ||
| final abbreviation = coinsGroup?.abbreviation ?? ''; | ||
| return '${context.i18n.wallet_coin_amount_insufficient} $abbreviation'; | ||
| } else if (parsed < 0) { | ||
| return context.i18n.wallet_coin_amount_must_be_positive; | ||
| } | ||
|
|
||
| // If we know decimals for the selected network, enforce min amount check | ||
| final decimals = coinForNetwork?.coin.decimals; | ||
| if (decimals != null) { | ||
| final amount = toBlockchainUnits(parsed, decimals); | ||
| if (amount == BigInt.zero && parsed > 0) { | ||
| return context.i18n.wallet_coin_amount_too_low_for_sending; | ||
| } | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have some veery similar logic here:
ion-framework/lib/app/features/wallets/views/pages/coins_flow/send_coins/components/coin_amount_input.dart
Line 59 in 03b551e
maybe something could be reused?