Skip to content

Conversation

@ice-erebus
Copy link
Contributor

Description

  • Move validation to button

Additional Notes

  • NA

Task ID

ION-5025

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation
  • Chore

Screenshots (if applicable)

Simulator Screenshot - iPhone 16 Pro - 2026-01-13 at 09 57 48

@ice-erebus ice-erebus requested review from a team and ice-brontes as code owners January 13, 2026 09:05
@ice-erebus ice-erebus changed the title feat: enhance error handling in token swap and trade community dialogs fix: enhance error handling in token swap and trade community dialogs Jan 13, 2026
@ice-morpheus ice-morpheus enabled auto-merge (squash) January 13, 2026 09:06
@ice-morpheus ice-morpheus force-pushed the bugfix/button-error-in-swap branch from 581a35e to da66071 Compare January 13, 2026 09:59
ice-brontes
ice-brontes previously approved these changes Jan 13, 2026
@ice-morpheus ice-morpheus force-pushed the bugfix/button-error-in-swap branch 5 times, most recently from b8f063c to ca8a0fa Compare January 13, 2026 11:16
@ice-morpheus ice-morpheus force-pushed the bugfix/button-error-in-swap branch 8 times, most recently from 4ccdbc0 to 65910c7 Compare January 14, 2026 10:08
@ice-erebus ice-erebus force-pushed the bugfix/button-error-in-swap branch 2 times, most recently from 2e4a804 to 230bbf6 Compare January 14, 2026 10:53
@ice-morpheus ice-morpheus force-pushed the bugfix/button-error-in-swap branch 2 times, most recently from 02d16f0 to aa85bd8 Compare January 14, 2026 14:36
@ice-morpheus ice-morpheus force-pushed the bugfix/button-error-in-swap branch 3 times, most recently from b80b403 to 4f0b756 Compare January 15, 2026 11:10
);
}

String? _validateAmount(
Copy link
Contributor

@ice-cerberus ice-cerberus Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have some veery similar logic here:

if (maxValue != null && (parsed > maxValue! || parsed < 0)) {

maybe something could be reused?

@ice-morpheus ice-morpheus force-pushed the bugfix/button-error-in-swap branch 14 times, most recently from ef48982 to d782811 Compare January 16, 2026 13:34
@ice-morpheus ice-morpheus force-pushed the bugfix/button-error-in-swap branch from d782811 to 9e1a795 Compare January 16, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants