-
Notifications
You must be signed in to change notification settings - Fork 12
fix: enhance error handling in token swap and trade community dialogs #3087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ice-erebus
wants to merge
3
commits into
master
Choose a base branch
from
bugfix/button-error-in-swap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+159
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
581a35e to
da66071
Compare
ice-brontes
previously approved these changes
Jan 13, 2026
b8f063c to
ca8a0fa
Compare
ice-tychon
reviewed
Jan 13, 2026
lib/app/features/wallets/views/pages/coins_flow/swap_coins/components/token_card.dart
Outdated
Show resolved
Hide resolved
ice-tychon
reviewed
Jan 13, 2026
lib/app/features/wallets/views/pages/coins_flow/swap_coins/components/token_card.dart
Outdated
Show resolved
Hide resolved
4ccdbc0 to
65910c7
Compare
2e4a804 to
230bbf6
Compare
02d16f0 to
aa85bd8
Compare
b80b403 to
4f0b756
Compare
| ); | ||
| } | ||
|
|
||
| String? _validateAmount( |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have some veery similar logic here:
Line 59 in 03b551e
| if (maxValue != null && (parsed > maxValue! || parsed < 0)) { |
maybe something could be reused?
ef48982 to
d782811
Compare
d782811 to
9e1a795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional Notes
Task ID
ION-5025
Type of Change
Screenshots (if applicable)