Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement in Market Section UI and Fixing portfolio page bugs Fix/#28 #39

Merged
merged 6 commits into from
Aug 17, 2020
Merged

Improvement in Market Section UI and Fixing portfolio page bugs Fix/#28 #39

merged 6 commits into from
Aug 17, 2020

Conversation

garimasingh22
Copy link
Collaborator

Fixes

What type of PR is this?

  • 🚀 Added Feature
  • 🐛 Fixed Bug
  • 📝 Docs Update
  • 🚩 Other

Check everything

  • I have added the issue number for which this pull request is created.
  • I have selected the TradeByte Project in Projects

Description

A clear and concise description

  • added favorite stocks section, displaying each stock horizontally
  • added general stock section which shows stocks from total-data.json file data
  • fixed alignment of portfolio.

@garimasingh22 garimasingh22 added bug Something isn't working enhancement New feature or request frontend Frontend Task labels Aug 17, 2020
@garimasingh22 garimasingh22 added this to the Week 2 milestone Aug 17, 2020
@garimasingh22 garimasingh22 self-assigned this Aug 17, 2020
@iampavangandhi iampavangandhi merged commit f70181b into iampavangandhi:master Aug 17, 2020
@iampavangandhi iampavangandhi linked an issue Aug 17, 2020 that may be closed by this pull request
Complete Market Section + Layout (UI) #28
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iampavangandhi iampavangandhi Awaiting requested review from iampavangandhi

Assignees

@garimasingh22 garimasingh22

Labels
bug Something isn't working enhancement New feature or request frontend Frontend Task
Projects
None yet
Milestone
Week 2
Development

Successfully merging this pull request may close these issues.

Complete Market Section + Layout (UI)
2 participants
@garimasingh22 @iampavangandhi