Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Market Section + Layout (UI) #28

Closed
iampavangandhi opened this issue Aug 11, 2020 · 0 comments · Fixed by #39 or #40
Closed

Complete Market Section + Layout (UI) #28

iampavangandhi opened this issue Aug 11, 2020 · 0 comments · Fixed by #39 or #40
Assignees
@garimasingh22
Labels
add feature Want a new feature enhancement New feature or request
Milestone
Week 2

Comments

@iampavangandhi
Copy link
Owner

iampavangandhi commented Aug 11, 2020 •
edited
Loading

Description

Task 1: The Layout _(nav.ejs) is not responsive for smartphones make it responsive + polish it a little (see the project-plan/ui-designs) for an Idea. ( done by @fabcodingzest )

Task 2: Make the market section both frontend and backend. make it responsive also. In Market Section on the top, there are popular stocks cards listed (horizontal scroll) from the data-compact.json file and below that, all the stock from the data-total.json file are listed use pagination to do that. (edited)

Suggestions and Tips
See the prebuild stuff you get the idea of how to implement market section

Additional context
(Optional) Implement Stock Search via Global Search Bar. See this
@iampavangandhi iampavangandhi added enhancement New feature or request add feature Want a new feature labels Aug 11, 2020
@iampavangandhi iampavangandhi added this to the Week 2 milestone Aug 11, 2020
@garimasingh22 garimasingh22 mentioned this issue Aug 17, 2020
Merged
6 tasks
iampavangandhi added a commit that referenced this issue Aug 17, 2020
@iampavangandhi
Merge pull request #39 from garimasingh22/fix/#28
f70181b 
Improvement in Market Section UI and Fixing portfolio page bugs Fix/#28
@iampavangandhi iampavangandhi linked a pull request Aug 17, 2020 that will close this issue
Improvement in Market Section UI and Fixing portfolio page bugs Fix/#28 #39
Merged
6 tasks
@garimasingh22 garimasingh22 mentioned this issue Aug 17, 2020
Merged
6 tasks
iampavangandhi added a commit that referenced this issue Aug 18, 2020
@iampavangandhi
Merge pull request #40 from garimasingh22/fix/#28
d51a6fc 
added symbol instead of image #28
iampavangandhi added a commit that referenced this issue Aug 24, 2020
@iampavangandhi
Merge branch 'master' into fix/#28
ac52fb8
iampavangandhi added a commit that referenced this issue Aug 24, 2020
@iampavangandhi
Merge pull request #57 from iampavangandhi/fix/#28
351b9a7 
Fix/#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garimasingh22 garimasingh22

Labels
add feature Want a new feature enhancement New feature or request
Projects
None yet
Milestone
Week 2
2 participants
@iampavangandhi @garimasingh22