Fix CI passing with failing tests

[ludfjig]

Fixes #138

Somehow pwsh won't always fail the job if a step fail.
This PR cannot merge until the tests are passing

[marosset]

IIRC you can have powershell check the $LASTEXITCODE or something similar which gets set when non-powershell processes are run.
Let me find an example from when I've had to use that int he past...
that might be cleaner than switching to bash (which may break things like env var setting)

[marosset]

super old but valid
https://github.com/Azure/aks-engine/blob/f634f52ff4f6295876b2d5391fc3af1f5bb3ad3e/vhd/packer/configure-windows-vhd.ps1#L146-L151

[marosset]

Maybe we can try updating set windows-shell to something like

set windows-shell := [
  "pwsh.exe",
  "-NoLogo",
  "-Command",
  " & { $cmd = $args -join ' '; Invoke-Expression $cmd; if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE } }"
]

[marosset]

Maybe we can try updating set windows-shell to something like

set windows-shell := [
  "pwsh.exe",
  "-NoLogo",
  "-Command",
  " & { $cmd = $args -join ' '; Invoke-Expression $cmd; if ($LASTEXITCODE -ne 0) { exit $LASTEXITCODE } }"
]

This is issues where powershell stops proccessing everything after the -- in some of the commands :-/

[simongdavies]

Just wondering if Mark's suggested change is better since IIUC this fix will work for the specific GH job but if the just command is run locally in Windows or from another GH job then the same failure will still be there?

[ludfjig]

Just wondering if Mark's suggested change is better since IIUC this fix will work for the specific GH job but if the just command is run locally in Windows or from another GH job then the same failure will still be there?

Mark and I dug a bit deeper into this. Unfortunately this is the only solution we came up with, as the other suggestions did not seem to work. Locally on windows, this doesn't modify anything, and at least on my computer, powershell behaves as expected and exits with the right exit code.

If this specific workflow gets invoked from somewhere else, the bash shell will still apply, however if in another workflow someone uses the same just-command without specific a bash-shell, indeed the problem will resurface again. @simongdavies

[marosset]

yes, i had issues getting anything after -- in the cargo commands to not be removed by powershell processing.
I tried a few things like adding --% after the .exe call and couldn't get anything to work

[simongdavies]

however if in another workflow someone uses the same just-command without specific a bash-shell, indeed the problem will resurface again

@ludfjig OK, can we put a comment in the just file somewhere to that effect then?

[marosset]

Will just commands continue to work from powershell on Windows machines.
Personally I don't like using bash on Windows and I would like to make sure the current behavior works if possible

[marosset]

So if i understand this correctly, the github CI runnings will spawn a bash shell which will run just, which will then spawn powershll shell's for whatever just executes?

Seems odd but if it gets us a better CI signal this works for me.

[ludfjig]

Will just commands continue to work from powershell on Windows machines. Personally I don't like using bash on Windows and I would like to make sure the current behavior works if possible

This only affects ci. Any just commands on windows will still spawn a pwsh shell (even on ci).