Fix CI passing with failing tests (#233)

* Test Signed-off-by: Ludvig Liljenberg <[email protected]> * Test 2 Signed-off-by: Ludvig Liljenberg <[email protected]> * revert unnecessary thigns Signed-off-by: Ludvig Liljenberg <[email protected]> * Add docs Signed-off-by: Ludvig Liljenberg <[email protected]> --------- Signed-off-by: Ludvig Liljenberg <[email protected]>
hyperlight-dev · Feb 7, 2025 · f9c4416 · f9c4416
1 parent 3954883
commit f9c4416
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/.github/workflows/dep_rust.yml b/.github/workflows/dep_rust.yml
@@ -20,6 +20,16 @@ permissions:
   id-token: write
   contents: read
 
+# The reason for default shell bash is because on our self-hosted windows runners,
+# the default shell is powershell, which doesn't work correctly together with `just` commands.
+# Even if a command inside a just-recipe fails, github reports the step as successful.
+# The problem may or may not be related to our custom windows runner not applying the
+# powershell steps outlined here 
+# https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference
+defaults:
+  run:
+    shell: bash
+
 jobs:
   build:
     if: ${{ inputs.docs_only == 'false' }}
@@ -71,7 +81,6 @@ jobs:
 
       - name: Verify MSRV
         run: ./dev/verify-msrv.sh hyperlight-host hyperlight-guest hyperlight-common
-        shell: bash
 
       - name: Run Rust tests
         env: