Skip to content

Commit f9c4416

Browse files
authored
Fix CI passing with failing tests (#233)
* Test Signed-off-by: Ludvig Liljenberg <[email protected]> * Test 2 Signed-off-by: Ludvig Liljenberg <[email protected]> * revert unnecessary thigns Signed-off-by: Ludvig Liljenberg <[email protected]> * Add docs Signed-off-by: Ludvig Liljenberg <[email protected]> --------- Signed-off-by: Ludvig Liljenberg <[email protected]>
1 parent 3954883 commit f9c4416

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

.github/workflows/dep_rust.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,16 @@ permissions:
2020
id-token: write
2121
contents: read
2222

23+
# The reason for default shell bash is because on our self-hosted windows runners,
24+
# the default shell is powershell, which doesn't work correctly together with `just` commands.
25+
# Even if a command inside a just-recipe fails, github reports the step as successful.
26+
# The problem may or may not be related to our custom windows runner not applying the
27+
# powershell steps outlined here
28+
# https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference
29+
defaults:
30+
run:
31+
shell: bash
32+
2333
jobs:
2434
build:
2535
if: ${{ inputs.docs_only == 'false' }}
@@ -71,7 +81,6 @@ jobs:
7181

7282
- name: Verify MSRV
7383
run: ./dev/verify-msrv.sh hyperlight-host hyperlight-guest hyperlight-common
74-
shell: bash
7584

7685
- name: Run Rust tests
7786
env:

0 commit comments

Comments
 (0)