Skip to content

Conversation

@brandon-pereira
Copy link
Member

When clicking outside the search hints or date modal, the modals close to prevent them appearing ontop of other modals when you click results

Screenshot 2025-10-24 at 11 07 49 AM Screenshot 2025-10-24 at 11 07 52 AM

Fixes HDX-2643

@brandon-pereira brandon-pereira requested review from a team and knudtty and removed request for a team October 24, 2025 09:08
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

🦋 Changeset detected

Latest commit: 992767e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Oct 27, 2025 6:55pm

@knudtty
Copy link
Contributor

knudtty commented Oct 24, 2025

add a changeset!

@claude
Copy link

claude bot commented Oct 24, 2025

Code Review

No critical issues found.

Both changes look good:

TimePicker.tsx:

  • Removing closeOnClickOutside={false} properly allows the modal to close when clicking outside
  • Follows standard Mantine Popover patterns

DBRowTable.tsx:

  • Removing e.stopPropagation() allows proper event bubbling for modal blur detection
  • Based on E2E tests passing (26 passed), the change doesn't break row expand functionality or nested button interactions

The PR successfully fixes the modal stacking issue described in HDX-2643.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2025

E2E Test Results

All tests passed • 25 passed • 3 skipped • 239s

Status Count
✅ Passed 25
❌ Failed 0
⚠️ Flaky 1
⏭️ Skipped 3

View full report →

Copy link
Contributor

@knudtty knudtty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@kodiakhq kodiakhq bot merged commit 757196f into main Oct 27, 2025
9 checks passed
@kodiakhq kodiakhq bot deleted the brandon/close-on-blur branch October 27, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants