Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UaClientOptions constructor public #66

Merged
merged 2 commits into from
Nov 30, 2017

Conversation

davidmn
Copy link

@davidmn davidmn commented Nov 30, 2017

A fix for #64 where by the example code in the README.md did not work.

Before this commit one needed to something like this to get an instance of UaClientOptions:

var dummyClient = new UaClient(new Uri("opc.tcp://host-url"));
var options = dummyClient.Options;
options.UserIdentity = new UserIdentity("username", "password");
using (var client = new UaClient(new Uri("opc.tcp://host-url"), options))
    {
        ...
    }

Which isn't very nice. This was because the constructor for UaClientOptions was internal.

@jmbeach
Copy link
Contributor

jmbeach commented Nov 30, 2017

Thanks for this pull request. Please see the appveyor build output. Stylecop gave an error because there are not XML comments on the now publicly visible constructor.

Please see Hyla Soft's CS Boilerplate guide for an explanation of our build system.

Thanks!

@davidmn
Copy link
Author

davidmn commented Nov 30, 2017

I'll get that fixed shortly.

@davidmn
Copy link
Author

davidmn commented Nov 30, 2017

I've added XML and the build passes.

@jmbeach jmbeach merged commit ced8b91 into hylasoft-usa:master Nov 30, 2017
@jmbeach
Copy link
Contributor

jmbeach commented Nov 30, 2017

Awesome, thanks! I'll create a new release

@jmbeach jmbeach mentioned this pull request Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants