Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C.tor for UaClientOptions #63

Closed
wants to merge 3 commits into from
Closed

C.tor for UaClientOptions #63

wants to merge 3 commits into from

Conversation

faraoman
Copy link

Added the constructor for UaClientOptions because isn't able to instantiate this class, necessary for making an authenticated communication

Added the constructor for UaClientOptions because isn't able to instantiate this class, necessary for making an authenticated communication
Copy link
Author

@faraoman faraoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment for C.tor and Init method

Copy link
Author

@faraoman faraoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add opening and closing curly brackets placed on their own line for C.tor

@jmbeach
Copy link
Contributor

jmbeach commented Nov 14, 2017

I do want options to have a public constructor. I do not want options to have a private "init" method. Also, style cop failed. See appveyor.

@jmbeach
Copy link
Contributor

jmbeach commented Nov 30, 2017

#66 Resolved this

@jmbeach jmbeach closed this Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants