Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent throw for second thread credentials call #2475

Merged
merged 1 commit into from
Dec 7, 2023
+2 −1
Merged

Prevent throw for second thread credentials call #2475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prevent throw for second thread call
@bgoncal
bgoncal committed Dec 7, 2023
commit a630a6effb8c87d117ecbfa4ea40ca9a732bb920
3 changes: 2 additions & 1 deletion Sources/App/ThreadCredentialsSharing/ThreadClientService.swift
View file
Original file line number Diff line number Diff line change
@@ -33,7 +33,8 @@ final class ThreadClientService: THClientProtocol {
let preferredCredential = try await client.preferredCredentials()

// All credentials retrieve the rest of the credentials after user acceps permission dialog
var allCredentials = try await client.allCredentials()
// This call may fail, but we don't want to throw error since preferredCredential succeeded
var allCredentials: Set<THCredentials> = (try? await client.allCredentials()) ?? []
allCredentials = allCredentials.filter { $0.borderAgentID != preferredCredential.borderAgentID }
allCredentials.insert(preferredCredential)