Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent throw for second thread credentials call #2475

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Dec 7, 2023

Summary

Prevent throw for second thread credentials call, since sometimes "preferredCredential" succeeds but "allCredentials" fail, we don't want to avoid showing the preferred credential.

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest December 7, 2023 19:20
@bgoncal bgoncal self-assigned this Dec 7, 2023
@bgoncal bgoncal force-pushed the thread-credentials-experiment branch from 5eb9784 to 90b4ffd Compare December 7, 2023 19:23
@bgoncal bgoncal force-pushed the thread-credentials-experiment branch from 90b4ffd to a630a6e Compare December 7, 2023 19:32
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 451 lines in your changes are missing coverage. Please review.

Comparison is base (8f7f0ec) 28.37% compared to head (a630a6e) 28.13%.
Report is 5 commits behind head on master.

Files Patch % Lines
...DropSupport/DropSupportMessageViewController.swift 0.00% 122 Missing ⚠️
...dentialsSharing/ThreadCredentialsSharingView.swift 0.00% 117 Missing ⚠️
Sources/App/WebView/WebViewController.swift 0.00% 90 Missing ⚠️
...alsSharing/ThreadCredentialsSharingViewModel.swift 38.46% 24 Missing ⚠️
...ces/App/Settings/DebugSettingsViewController.swift 0.00% 21 Missing ⚠️
...rces/Shared/DesignSystem/Components/CardView.swift 0.00% 21 Missing ⚠️
...rces/Shared/DesignSystem/Components/HAButton.swift 0.00% 14 Missing ⚠️
Sources/Shared/Environment/MatterWrapper.swift 0.00% 12 Missing ⚠️
...ntialsSharing/ThreadCredentialsSharing+build.swift 0.00% 8 Missing ⚠️
Sources/App/AppDelegate.swift 0.00% 6 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2475      +/-   ##
==========================================
- Coverage   28.37%   28.13%   -0.24%     
==========================================
  Files         273      285      +12     
  Lines       30284    30784     +500     
==========================================
+ Hits         8593     8661      +68     
- Misses      21691    22123     +432     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit cdc2f14 into master Dec 7, 2023
7 checks passed
@bgoncal bgoncal deleted the thread-credentials-experiment branch December 7, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants