WIP: Fix various issues #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating from remote master.
Address Issue hiiamrohit#5
Name correction for Republic of the Congo and The Democratic Republic of the Congo
This was referenced Apr 3, 2018
Closed
Contributor
Author
|
I'll add some more unit tests tomorrow to do basic checks like make sure all countries have states and all states cities, etc. |
Contributor
Author
|
After that I'll mark this PR as ready to be merged. |
|
São Paulo (537) still has no cities. |
Contributor
Author
|
Fix issue #32. |
Merged
…dreamercsw/Countries-States-Cities-database into javydreamercsw-fix-issue-32
|
Hey, great work there. When will this be merged? |
Contributor
Author
|
Owner has been MIA for a while. |
|
Yes I noticed. Meanwhile I found the geolite list that contains almost 1M cities, if you're interested in including those here, but first you'd have to check for duplicates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.