Skip to content

Conversation

@balthild
Copy link
Contributor

Some states and cities data are obsolete, I've deleted it.

@javydreamercsw
Copy link
Contributor

It looks clean besides I haven't checked the reason behind them being obsolete. Could you elaborate on why they are obsolete? Is not like they were wiped out of the face of the earth.

Are they duplicated instead? If so can you provide more detail?

@balthild
Copy link
Contributor Author

Anhui, Anhui Province, Anhui Sheng
Fujian, Fujian Sheng
Jiangsu, Jiangsu Sheng
Liaoning, Liaoning Sheng
Shandong, Shandong Sheng
Zhejiang, Zhejiang Sheng
The word Sheng means Province in Chinese. They refers to a same place whether with or without a Sheng or a Province.

@javydreamercsw
Copy link
Contributor

So for example keep Anhui, and delete Anhui Province, Anhui Sheng?

@javydreamercsw
Copy link
Contributor

Are those the only ones?

@javydreamercsw
Copy link
Contributor

It would be easier if you provide the modified file for review.

@balthild
Copy link
Contributor Author

Yes, these province are the only ones in China. I'm a Chinese, you see.
The commit i requested (4b07d94cd68a41a6fa77b9990523d21128ba2151) is the modification.

@javydreamercsw
Copy link
Contributor

I'm including your changes on PR #46.

javydreamercsw added a commit to javydreamercsw/Countries-States-Cities-database that referenced this pull request Apr 5, 2018
@hiiamrohit hiiamrohit merged commit aca26b6 into hiiamrohit:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants