-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ./bin/bump version.py
on macOS
#356
Fix ./bin/bump version.py
on macOS
#356
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 2978 2978
=========================================
Hits 2978 2978 ☔ View full report in Codecov by Sentry. |
I think the macOS runners were having a bad time earlier, seems ok now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OSX madness, but never mind!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies -- I didn't realise this was ready to go -- the red cross is misleading due to the failing but not essential checks.
the ❌ indeed do not spark joy. I kind of lost motivation with #359 since some of the warnings go away with recent development pandas |
Description
./bin/bump_version.py
was not working on macOS, as its version ofsed
requires an backup for in-place editing, or an empty string to turn it off (-i''
, without the space).I tried to do something more subtle that would work cross-platform, but getting an empty string argument into
subprocess.run()
doesn't seem straightforward. I think a cleaner solution would be to automate this entirely in python or bash rather than mixing the two, but of course at the cost of a larger diff.Fixes #355
Checklist:
flake8 anesthetic tests
)pydocstyle --convention=numpy anesthetic
)python -m pytest
)