-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast root
to str
to allow e.g. a pathlib.Path
object to be used
#358
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 34 34
Lines 2978 2979 +1
=========================================
+ Hits 2978 2979 +1 ☔ View full report in Codecov by Sentry. |
root
to str
to allow e.g. a pathlib.Path
object to be usedroot
to str
to allow e.g. a pathlib.Path
object to be used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a pretty reasonable extension (version number and readme need bumping, but will re-approve
will do once #356 is through |
Will be a nice opportunity to test that bump_version actually works on osx after #356 is merged |
I could test OS X compat |
If you like, but I'm also on Mac hence #356 in the first place |
Will was too fast 😢 was confused why my branch had diverged in seconds |
Ah, apologies for stealing your fun! The bump version isn't much use in a merge resolution anyway. We'll have to wait until a new PR before trying #356 out on macOS |
dw I'll try it out on #359 |
Description
A quick one: I'm a fan of
pathlib.Path
, which takes care of/
vs\
on unix/dos derived OSs, however, it cannot be used as theread_chains
root
argument since+
is not defined for aPath
, so I just cast it to string.This PR puts the cast into
read_chains
. I have left all the other reading functions unmodified since they aren't intended to be invoked directly.Fixes #357
Checklist:
flake8 anesthetic tests
)pydocstyle --convention=numpy anesthetic
)python -m pytest
)