Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit, egui and vulkano #53

Merged
merged 27 commits into from
Feb 13, 2025
Merged

Update winit, egui and vulkano #53

merged 27 commits into from
Feb 13, 2025

Conversation

Letronix624
Copy link
Contributor

@Letronix624 Letronix624 commented Jan 13, 2024

Updates winit egui vulkano and the crates below that.

Stays a draft as long as vulkano has not released it's changes.

@hakolao
Copy link
Owner

hakolao commented Jan 15, 2024

You could update this draft using a link to a specific commit id from vulkano repo in Cargo.toml. That way we could do

Wait for vulkano 0.25 to roll out and revisit this draft, easily applying the new utils version with winit 0.29 and therefore avoid being current until Vulkano is.

And meanwhile you could use this branch in your project. And when 0.25 is out, just replace the dependency with that.

Thoughts?

I personally prefer the simplicity of using vulkano-util in the examples keeping them clean.

@Letronix624
Copy link
Contributor Author

Yes, I also had that idea. Alright

@Letronix624 Letronix624 changed the title Update winit and egui Update winit and egui and vulkano Jan 16, 2024
@Letronix624 Letronix624 changed the title Update winit and egui and vulkano Update winit, egui and vulkano Jan 16, 2024
@Letronix624 Letronix624 force-pushed the master branch 2 times, most recently from 7c1abc9 to 0bd84c7 Compare February 12, 2024 16:00
@hakolao
Copy link
Owner

hakolao commented Apr 9, 2024

Happy to get this merged when vulkano 0.35 is out, and make a release.

Letronix624 and others added 6 commits July 25, 2024 15:26
vulkano -> upstream, winit -> 0.30, egui -> 0.29
This is in order to avoid random breakage when Vulkano gets an update.

Gets removed as soon as Vulkano releases a new version.
rename RecordingCommandBuffers and CommandBuffers back to AutoCommandBufferBuilder and their previous names
Use PrimaryCommandBufferAbstract again
@LDeakin
Copy link

LDeakin commented Feb 7, 2025

Vulkano 0.35 has released https://github.com/vulkano-rs/vulkano/releases/tag/v0.35.0

@Letronix624 Letronix624 marked this pull request as ready for review February 7, 2025 06:19
@giuseppeferrari
Copy link

giuseppeferrari commented Feb 8, 2025

Hi @Letronix624 !
I tried your branch and noted two strange behaviours in the examples:

  1. Demo_app
    The "Color" (when opened) grows at each frame on the right until it becomes larger than the screen. Not sure if it stops or continue growing "forever".
    Note that, if I reduce the window size and then enlarge again sometimes ( no clear under which conditions ) the window return small and the grow restarts.
    image

  2. Subpass and similar examples
    The egui Frame seems odd (not sure if it is desired / expected, anyway).
    image

Configuration:

  • Windows 10
  • rustc 1.84.1 (e71f9a9a9 2025-01-27)
  • NVIDIA GeForce RTX 3060 with GameReady driver, 572.16

@Letronix624
Copy link
Contributor Author

Hello @giuseppeferrari ,
Thank you for reaching out and pointing out a problem before merge.
The first issue you are experiencing does not originate from this crate and would also occur if you opened the color window in eframe. For this create an issue at the egui repository.
Your second issue I can not recreate. Please attempt this in the update function of eframe on your device:

Window::new("Transparent Window")
    .anchor(Align2([Align::RIGHT, Align::TOP]), vec2(-545.0, 500.0))
    .resizable(false)
    .default_width(300.0)
    .frame(
        Frame::NONE
            .fill(Color32::from_white_alpha(125))
            .shadow(Shadow {
                spread: 8,
                blur: 10,
                color: Color32::from_black_alpha(125),
                ..Default::default()
            })
            .corner_radius(CornerRadius::same(5))
            .inner_margin(Margin::same(10)),
    )
    .show(&ctx, |ui| {
        ui.colored_label(Color32::BLACK, "Content :)");
    });

If the exact issue persists in eframe, also send an issue to egui.

@giuseppeferrari
Copy link

Hi Lextronik624,
unfortunately the issue does not show with eFrame;
I'll try to investigate further to provide more details.
Thanks for your extraordinary work, BTW.

@hakolao
Copy link
Owner

hakolao commented Feb 13, 2025

Can I merge? @Letronix624 . All worked, (apart from the ever expanding color window)

@Letronix624
Copy link
Contributor Author

Yes.

@hakolao hakolao merged commit 0e2f347 into hakolao:master Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants