[query] reduce uses of fs.open with compression #15196
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 18, 2025
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ehigham
force-pushed
the
ehigham/limit-open-compression-uses
branch
from
10dec30 to
cb7c670
Compare
ehigham
force-pushed
the
ehigham/scala-fs-extract-primitives
branch
from
6079d3d to
0bcda90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR refactors stream handling in the codebase by introducing buffering and byte tracking utilities as extension methods. It adds
RichCodeInputStreamandRichCodeOutputStreamclasses with methods likebufferandtrackBytesto simplify stream creation and management.The changes remove direct instantiation of
BufferedInputStream,BufferedOutputStream, andByteTrackingOutputStreamthroughout the codebase, replacing them with the new extension methods. This standardizes stream handling and makes the code more consistent.The PR also updates various file operations in
EmitClassBuilder,MatrixWriter,TableWriter, and other classes to use these new utilities, ensuring consistent stream handling across the codebase.Security Assessment
This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP