[query] remove non-primitives from scala fs #15178
Open
+305
−303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ehigham
force-pushed
the
ehigham/scala-fs-cleanup
branch
from
38bd775 to
7ea3e1a
Compare
ehigham
force-pushed
the
ehigham/scala-fs-extract-primitives
branch
from
ac8c10a to
63d9631
Compare
ehigham
force-pushed
the
ehigham/scala-fs-cleanup
branch
from
7ea3e1a to
7bdccf4
Compare
ehigham
force-pushed
the
ehigham/scala-fs-extract-primitives
branch
from
63d9631 to
351551b
Compare
ehigham
force-pushed
the
ehigham/scala-fs-extract-primitives
branch
3 times, most recently
from
05617b0 to
6079d3d
Compare
ehigham
force-pushed
the
ehigham/scala-fs-extract-primitives
branch
from
6079d3d to
0bcda90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved utility functions from the
FStrait to a package object, reducing the size of the trait. Converted methods likegetCodecFromPath,getExtension, andgetCodecExtensioninto standalone functions. Also improved error handling by usingOptionfor codec returns instead of nullable values, and implemented pattern matching for cleaner code.This change cannot impact the Hail Batch instance as deployed by Broad Institute in GCP