Skip to content

Add compatibility for php 8.4 by removing deprecation warnings #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PNardman
Copy link

Feature or problem being solved

Adding explicit nullable to parameters since implicit nullable parameters are deprecated in PHP 8.4

Affected code:

Status::L35
Satus::L47
ServerCallWrite::L94

Further details

Adding the explicit nullable parameter, gets rid of unnecessary deprecation warnings for php 8.4, however since we need to support php 7 we need to remove the type hinting, since php 7 does not support this feature.

Links / references

Implicitly nullable values are deprecated in php 8.4.

See:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Copy link

CLA Missing ID CLA Not Signed

@shu-yusa
Copy link

I think we should differentiate the (major) version to support 8.4 instead of removing the typing, and drop the support for php7?

@shu-yusa
Copy link

since php versions 7.x and 8.1 have reached EOL (https://www.php.net/supported-versions.php), how's dropping the support of 7.0 - 8.1, and publish the release as 2.0.0 for example? what do you think? cc: @stanley-cheung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants