Add compatibility for php 8.4 by removing deprecation warnings #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or problem being solved
Adding explicit nullable to parameters since implicit nullable parameters are deprecated in PHP 8.4
Affected code:
Status::L35
Satus::L47
ServerCallWrite::L94
Further details
Adding the explicit nullable parameter, gets rid of unnecessary deprecation warnings for php 8.4, however since we need to support php 7 we need to remove the type hinting, since php 7 does not support this feature.
Links / references
Implicitly nullable values are deprecated in php 8.4.
See:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated