Add PHP8.4 support, drop support of EOL PHP versions #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PNardman @stanley-cheung How's changing like this, and tagging 2.0.0 by the release? |
Plus one would love this! |
|
Nice I need this as well 💪🏽 |
|
@stanley-cheung would you be able to take a look at this PR? |
|
Everyone is still waiting for this. 🙏 |
|
I noticed the README says a request should be sent to https://github.com/grpc/grpc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PHP8.4, a parameter that has
nullas a default value has to be typed as a nullable type: https://www.php.net/manual/en/migration84.deprecated.phpIn the code base, the factory methods of
Statusclass have to be fixed to comply with this syntax. On the other hand, as pointed out in #37, nullable type is not available in 7.0 (https://www.php.net/manual/en/migration71.new-features.php), which is supported in this library.Since the versions 7.0 - 8.0 have reached the EOL (https://www.php.net/supported-versions.php) as of now, I would like to propose dropping support of these versions, and adding support of 8.4. In order not to break users who are using this library in these EOL versions, I think the major version should be lifted.
I also found the library
google/authis not used in any place in the code base. It should be added by library users if necessary, rather than by this library.