-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacto enum equipment type #400
Conversation
antoinebhs
commented
Dec 19, 2023
- Use enum for equipmentType
Signed-off-by: BOUHOURS Antoine <[email protected]>
…y handled. Code fixes. Signed-off-by: BOUHOURS Antoine <[email protected]>
Add support for deleting equipments by filter Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: Antoine Bouhours <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
95b39c6
to
7c1476d
Compare
@@ -34,7 +34,7 @@ public EquipmentDeletion(EquipmentDeletionInfos modificationInfos) { | |||
|
|||
@Override | |||
public void apply(Network network, Reporter subReporter) { | |||
Identifiable<?> identifiable = ModificationUtils.getInstance().getEquipmentByIdentifiableType(network, modificationInfos.getEquipmentType(), modificationInfos.getEquipmentId()); | |||
Identifiable<?> identifiable = ModificationUtils.getInstance().getEquipmentByIdentifiableType(network, modificationInfos.getEquipmentType().name(), modificationInfos.getEquipmentId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double conversion ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SlimaneAmar I updated the code to avoid the double conversion. I note that regulating terminal type also use a String
Line 45 in c535de6
private String regulatingTerminalType; |
Signed-off-by: BOUHOURS Antoine <[email protected]>
…ion-server into refacto-enum-equipment-type Signed-off-by: BOUHOURS Antoine <[email protected]>
|