Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto enum equipment type #400

Merged
merged 21 commits into from
Dec 21, 2023
Merged

Refacto enum equipment type #400

merged 21 commits into from
Dec 21, 2023

Conversation

antoinebhs
Copy link
Contributor

  • Use enum for equipmentType

antoinebhs and others added 18 commits December 8, 2023 15:27
…y handled.

Code fixes.

Signed-off-by: BOUHOURS Antoine <[email protected]>
Add support for deleting equipments by filter

Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: Antoine Bouhours <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs antoinebhs changed the base branch from main to add-by-filter-deletion December 19, 2023 14:39
Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs antoinebhs force-pushed the refacto-enum-equipment-type branch from 95b39c6 to 7c1476d Compare December 19, 2023 14:41
@FranckLecuyer FranckLecuyer self-requested a review December 19, 2023 14:58
@@ -34,7 +34,7 @@ public EquipmentDeletion(EquipmentDeletionInfos modificationInfos) {

@Override
public void apply(Network network, Reporter subReporter) {
Identifiable<?> identifiable = ModificationUtils.getInstance().getEquipmentByIdentifiableType(network, modificationInfos.getEquipmentType(), modificationInfos.getEquipmentId());
Identifiable<?> identifiable = ModificationUtils.getInstance().getEquipmentByIdentifiableType(network, modificationInfos.getEquipmentType().name(), modificationInfos.getEquipmentId());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double conversion ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SlimaneAmar I updated the code to avoid the double conversion. I note that regulating terminal type also use a String

Signed-off-by: BOUHOURS Antoine <[email protected]>
Base automatically changed from add-by-filter-deletion to main December 21, 2023 16:33
…ion-server into refacto-enum-equipment-type

Signed-off-by: BOUHOURS Antoine <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
84.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@antoinebhs antoinebhs merged commit c2a3563 into main Dec 21, 2023
3 checks passed
@antoinebhs antoinebhs deleted the refacto-enum-equipment-type branch December 21, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants