-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add by filter deletion #390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BOUHOURS Antoine <[email protected]>
…y handled. Code fixes. Signed-off-by: BOUHOURS Antoine <[email protected]>
Add support for deleting equipments by filter Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: Antoine Bouhours <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
a1b6b54
to
c900313
Compare
flomillot
reviewed
Dec 18, 2023
src/main/java/org/gridsuite/modification/server/dto/ByFilterDeletionInfos.java
Outdated
Show resolved
Hide resolved
flomillot
reviewed
Dec 18, 2023
...va/org/gridsuite/modification/server/entities/equipment/deletion/ByFilterDeletionEntity.java
Outdated
Show resolved
Hide resolved
SlimaneAmar
reviewed
Dec 18, 2023
src/main/java/org/gridsuite/modification/server/ModificationType.java
Outdated
Show resolved
Hide resolved
flomillot
reviewed
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with tests, but maybe create a specific folder ?
...va/org/gridsuite/modification/server/entities/equipment/deletion/ByFilterDeletionEntity.java
Outdated
Show resolved
Hide resolved
...t/java/org/gridsuite/modification/server/modifications/VoltageLevelByFilterDeletionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: BOUHOURS Antoine <[email protected]>
dc5e020
to
00dde0b
Compare
Signed-off-by: BOUHOURS Antoine <[email protected]>
3daea0e
to
26db753
Compare
flomillot
approved these changes
Dec 19, 2023
SlimaneAmar
reviewed
Dec 20, 2023
...va/org/gridsuite/modification/server/entities/equipment/deletion/ByFilterDeletionEntity.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ByFilterDeletion.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ByFilterDeletion.java
Outdated
Show resolved
Hide resolved
Signed-off-by: BOUHOURS Antoine <[email protected]>
c1aa16d
to
efbed3f
Compare
Signed-off-by: BOUHOURS Antoine <[email protected]>
SlimaneAmar
approved these changes
Dec 21, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for deleting equipments by filter.