Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add by filter deletion #390

Merged
merged 22 commits into from
Dec 21, 2023
Merged

Add by filter deletion #390

merged 22 commits into from
Dec 21, 2023

Conversation

antoinebhs
Copy link
Contributor

Add support for deleting equipments by filter.

…y handled.

Code fixes.

Signed-off-by: BOUHOURS Antoine <[email protected]>
Add support for deleting equipments by filter

Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs antoinebhs changed the base branch from main to refacto-filter-modification December 8, 2023 15:27
Signed-off-by: BOUHOURS Antoine <[email protected]>
Base automatically changed from refacto-filter-modification to main December 13, 2023 12:25
antoinebhs and others added 11 commits December 13, 2023 16:55
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
Signed-off-by: Antoine Bouhours <[email protected]>
Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs antoinebhs force-pushed the add-by-filter-deletion branch from a1b6b54 to c900313 Compare December 15, 2023 12:02
Copy link
Contributor

@flomillot flomillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with tests, but maybe create a specific folder ?

@antoinebhs antoinebhs force-pushed the add-by-filter-deletion branch from dc5e020 to 00dde0b Compare December 19, 2023 12:46
Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs antoinebhs force-pushed the add-by-filter-deletion branch from 3daea0e to 26db753 Compare December 19, 2023 14:14
Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs antoinebhs force-pushed the add-by-filter-deletion branch from c1aa16d to efbed3f Compare December 21, 2023 09:23
Copy link

@antoinebhs antoinebhs merged commit ad451b3 into main Dec 21, 2023
3 checks passed
@antoinebhs antoinebhs deleted the add-by-filter-deletion branch December 21, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants