support minBindingSize in bindGroupLayouts

greggman · Jul 2, 2024 · 6cf4052 · 6cf4052
1 parent 1ca52b6
commit 6cf4052
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 13 deletions.
diff --git a/src/data-definitions.ts b/src/data-definitions.ts
@@ -281,14 +281,17 @@ function getBindGroupLayoutEntry(resource: VariableInfo, visibility: GPUShaderSt
             return {
                 binding,
                 visibility,
-                buffer: { },
+                buffer: {
+                    ...(resource.size && { minBindingSize: resource.size }),
+                },
             };
         case ResourceType.Storage:
             return {
                 binding,
                 visibility,
                 buffer: {
                     type: (access === '' || access === 'read') ? 'read-only-storage' : 'storage',
+                    ...(resource.size && { minBindingSize: resource.size }),
                 },
             };
         case ResourceType.Texture: {

diff --git a/test/tests/data-definition-test.js b/test/tests/data-definition-test.js
@@ -216,8 +216,8 @@ describe('data-definition-tests', () => {
       @group(0) @binding(5) var texExt: texture_external;
       @group(1) @binding(0) var<uniform> u: mat4x4f;
       @group(1) @binding(1) var<storage> s: mat4x4f;
-      @group(1) @binding(2) var<storage, read> sr: mat4x4f;
-      @group(1) @binding(3) var<storage, read_write> srw: mat4x4f;
+      @group(1) @binding(2) var<storage, read> sr: array<vec4f, 10>;
+      @group(1) @binding(3) var<storage, read_write> srw: array<vec4f>;
       @group(3) @binding(0) var tsR: texture_storage_2d<rgba8unorm, read>;
       @group(3) @binding(1) var tsW: texture_storage_2d<rgba32float, write>;
       @group(3) @binding(2) var tsRW: texture_storage_2d<rgba16uint, read_write>;
@@ -283,21 +283,29 @@ describe('data-definition-tests', () => {
           },
           "sr": {
             "typeDefinition": {
-              "size": 64,
-              "type": "mat4x4f",
+              "size": 160,
+              "numElements": 10,
+              "elementType": {
+                "size": 16,
+                "type": "vec4f",
+              },
             },
             "group": 1,
             "binding": 2,
-            "size": 64,
+            "size": 160,
           },
           "srw": {
             "typeDefinition": {
-              "size": 64,
-              "type": "mat4x4f",
+              "size": 0,
+              "numElements": 0,
+              "elementType": {
+                "size": 16,
+                "type": "vec4f",
+              },
             },
             "group": 1,
             "binding": 3,
-            "size": 64,
+            "size": 0,
           },
         },
         "storageTextures": {
@@ -449,7 +457,9 @@ describe('data-definition-tests', () => {
                 "entry": {
                   "binding": 0,
                   "visibility": 1,
-                  "buffer": {},
+                  "buffer": {
+                    "minBindingSize": 64,
+                  },
                 },
               },
               {
@@ -460,6 +470,7 @@ describe('data-definition-tests', () => {
                   "visibility": 1,
                   "buffer": {
                     "type": "read-only-storage",
+                    "minBindingSize": 64,
                   },
                 },
               },
@@ -471,6 +482,7 @@ describe('data-definition-tests', () => {
                   "visibility": 1,
                   "buffer": {
                     "type": "read-only-storage",
+                    "minBindingSize": 160,
                   },
                 },
               },
@@ -546,8 +558,8 @@ describe('data-definition-tests', () => {
         @group(0) @binding(5) var texExt: texture_external;
         @group(1) @binding(0) var<uniform> u: mat4x4f;
         @group(1) @binding(1) var<storage> s: mat4x4f;
-        @group(1) @binding(2) var<storage, read> sr: mat4x4f;
-        @group(1) @binding(3) var<storage, read_write> srw: mat4x4f;
+        @group(1) @binding(2) var<storage, read> sr: array<vec4f, 10>;
+        @group(1) @binding(3) var<storage, read_write> srw: array<vec4f>;
         @group(3) @binding(0) var tsR: texture_storage_2d<rgba8unorm, read>;
         @group(3) @binding(1) var tsW: texture_storage_2d<rgba32float, write>;
         @group(3) @binding(2) var tsRW: texture_storage_2d<rgba16uint, read_write>;
@@ -630,20 +642,24 @@ describe('data-definition-tests', () => {
               {
                 binding: 0,
                 visibility: 1,
-                buffer: {},
+                buffer: {
+                  minBindingSize: 64,
+                },
               },
               {
                 binding: 1,
                 visibility: 1,
                 buffer: {
                   type: 'read-only-storage',
+                  minBindingSize: 64,
                 },
               },
               {
                 binding: 2,
                 visibility: 1,
                 buffer: {
                   type: 'read-only-storage',
+                  minBindingSize: 160,
                 },
               },
               {
@@ -816,6 +832,7 @@ describe('data-definition-tests', () => {
                 binding: 1,
                 visibility: 4,
                 buffer: {
+                  minBindingSize: 16,
                 },
               },
             ],
@@ -858,12 +875,14 @@ describe('data-definition-tests', () => {
                   binding: 3,
                   visibility: 4,
                   buffer: {
+                    minBindingSize: 16,
                   },
                 },
                 {
                   binding: 4,
                   visibility: 4,
                   buffer: {
+                    minBindingSize: 16,
                   },
                 },
               ],
@@ -899,6 +918,7 @@ describe('data-definition-tests', () => {
                   binding: 3,
                   visibility: 1,
                   buffer: {
+                    minBindingSize: 16,
                   },
                 },
               ],