Skip to content

tctl resources: convert db #60360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 17, 2025
Merged

tctl resources: convert db #60360

merged 5 commits into from
Oct 17, 2025

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 commented Oct 17, 2025 •
edited
Loading

@greedy52 greedy52 self-assigned this Oct 17, 2025
@greedy52 greedy52 added the no-changelog Indicates that a PR does not require a changelog entry label Oct 17, 2025
@greedy52 greedy52 force-pushed the STeve/59518_tctl_db branch from f3c7362 to 3ecb677 Compare October 17, 2025 15:48
@greedy52 greedy52 marked this pull request as ready for review October 17, 2025 15:52
@github-actions github-actions bot requested a review from kopiczko October 17, 2025 15:52
@github-actions github-actions bot added size/md tctl tctl - Teleport admin tool labels Oct 17, 2025
greedy52
greedy52 commented Oct 17, 2025
View reviewed changes
tool/tctl/common/resources/database.go
return nil
}

func updateDatabase(ctx context.Context, client *authclient.Client, raw services.UnknownResource, opts CreateOpts) error {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is new

tool/tctl/common/resources/utils.go
Comment on lines +33 to +34
// AltResourceNameFunc is a func that returns an alternative name for a resource.
type AltResourceNameFunc[T types.ResourceWithLabels] func(T) string
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved some helpers (and their UT). no new logic.

hugoShaka
hugoShaka reviewed Oct 17, 2025
View reviewed changes
@greedy52 greedy52 requested a review from hugoShaka October 17, 2025 16:33
@greedy52
Copy link
Contributor Author

greedy52 commented Oct 17, 2025 •
edited
Loading

UT initially failing in a case where multiple db resources in the same file for create. fix dd84871

rosstimothy
rosstimothy approved these changes Oct 17, 2025
View reviewed changes
@greedy52 greedy52 mentioned this pull request Oct 17, 2025
Open
77 tasks
@greedy52 greedy52 enabled auto-merge October 17, 2025 18:44
@greedy52 greedy52 added this pull request to the merge queue Oct 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@greedy52 greedy52 added this pull request to the merge queue Oct 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2025
@greedy52 greedy52 added this pull request to the merge queue Oct 17, 2025
Merged via the queue into master with commit 3598261 Oct 17, 2025
43 checks passed
@greedy52 greedy52 deleted the STeve/59518_tctl_db branch October 17, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugoShaka hugoShaka hugoShaka approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

Assignees

@greedy52 greedy52

Labels

no-changelog Indicates that a PR does not require a changelog entry size/md tctl tctl - Teleport admin tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@greedy52 @hugoShaka @rosstimothy