Convert tctl resources to the handler format

[hugoShaka]

• scopedaccess.KindScopedRole
• scopedaccess.KindScopedRoleAssignment
• types.KindAccessGraphSettings @avatus tctl resource: update AccessGraphSettings #60566
• types.KindAccessList
• types.KindAccessMonitoringRule @bernardjkim
• types.KindAccessRequest
• types.KindApp @greedy52 tctl resource: convert app, app_server #60406
• types.KindAppServer @greedy52 tctl resource: convert app, app_server #60406
• types.KindAuditQuery
• types.KindAuthServer tctl resources: convert Auth, Proxy, Node #60383
• types.KindAutoUpdateAgentReport Convert autoupdate_* resources to the new tctl handler format #60470
• types.KindAutoUpdateAgentRollout Convert autoupdate_* resources to the new tctl handler format #60470
• types.KindAutoUpdateBotInstanceReport Convert MWI tctl resources to new handler format #60399
• types.KindAutoUpdateConfig Convert autoupdate_* resources to the new tctl handler format #60470
• types.KindAutoUpdateVersion Convert autoupdate_* resources to the new tctl handler format #60470
• types.KindBot Convert MWI tctl resources to new handler format #60399
• types.KindBotInstance Convert MWI tctl resources to new handler format #60399
• types.KindCertAuthority
• types.KindClusterAuthPreference
• types.KindClusterMaintenanceConfig
• types.KindClusterNetworkingConfig
• types.KindConnectors
• types.KindCrownJewel
• types.KindDatabase tctl resources: convert db #60360
• types.KindDatabaseObject tctl resource: database object #60719
• types.KindDatabaseObjectImportRule tctl resource: database object import rule #60567
• types.KindDatabaseServer @GavinFrazar
• types.KindDatabaseService @GavinFrazar
• types.KindDevice
• types.KindDiscoveryConfig tctl resource: convert discovery_config handler #60402
• types.KindDynamicWindowsDesktop
• types.KindExternalAuditStorage
• types.KindGitServer tctl resource: convert git_server #60474
• types.KindGithubConnector
• types.KindHealthCheckConfig @GavinFrazar
• types.KindInferenceModel
• types.KindInferencePolicy
• types.KindInferenceSecret
• types.KindInstaller @cthach tctl resource: Convert types.KindInstaller to Handler format #60639
• types.KindIntegration @marcoandredinis
• types.KindKubeServer
• types.KindKubernetesCluster
• types.KindLock tctl resource: convert lock handler #60300
• types.KindLoginRule
• types.KindNamespace Remove tctl get namespaces #60500
• types.KindNetworkRestrictions
• types.KindNode tctl resources: convert Auth, Proxy, Node #60383
• types.KindOIDCConnector
• types.KindOktaAssignment
• types.KindOktaImportRule
• types.KindPlugin
• types.KindProxy tctl resources: convert Auth, Proxy, Node #60383
• types.KindRelayServer
• types.KindRemoteCluster
• types.KindReverseTunnel
• types.KindRole (add new tctl resource handler types and logic #59518)
• types.KindSAMLConnector
• types.KindSAMLIdPServiceProvider @flyinghermit
• types.KindSPIFFEFederation Convert MWI tctl resources to new handler format #60399
• types.KindSecurityReport
• types.KindSemaphore
• types.KindServerInfo
• types.KindSessionRecordingConfig
• types.KindSigstorePolicy Convert MWI tctl resources to new handler format #60399
• types.KindStaticHostUser
• types.KindToken
• types.KindTrustedCluster
• types.KindUIConfig @avatus tctl resource: convert ui_config handler #60532
• types.KindUser tctl resources: convert users #60332
• types.KindUserGroup
• types.KindUserTask @marcoandredinis
• types.KindVnetConfig
• types.KindWindowsDesktop
• types.KindWindowsDesktopService
• types.KindWorkloadIdentity Convert MWI tctl resources to new handler format #60399
• types.KindWorkloadIdentityX509IssuerOverride Convert MWI tctl resources to new handler format #60399
• types.KindWorkloadIdentityX509Revocation Convert MWI tctl resources to new handler format #60399

[cthach]

I want to contribute although I'm not familiar with this new handler format we're trying to migrate to.

@hugoShaka Can you please give me some context?

[hugoShaka]

Sure, basically before, in tool/tctl/common we had:

• one collection for each resource
• (optional) one create function
• (optional) one update function
• a case in the giant switch in ResourceCommand.getCollection
• (optional) a case in the giant switch in ResourceCommand.Delete

In #59518 we added a new package tool/tctl/common/resources with the Handler struct. The goal is to move all the logic handling a specific resource into its dedicated tool/tctl/common/resources/<resource-kind>.go file, create a Handler and register it in the Handlers() func in tool/tctl/common/resources/resource.go.

The wiring is already done so that any new registered handler will be used if we try to tctl get/create/udpate/delete/edit its kind.

You can find an example conversion PR here: #60300

The handler opts and signature were designed to be very similar to the existing functions, so most of the conversion is copying code around and renaming the opts variable. For some resource, their collection might be used by some other tctl commands, in this case you'll have to make a public NewXCollection() function for compatibility.

A good first resource would be types.KindInstaller because it's not a singleton, no other command uses it, and there's no weird thing like for sso connectors or tokens.

Feel free to slack me if you have questions

[cthach]

Sure, basically before, in tool/tctl/common we had:

• one collection for each resource
• (optional) one create function
• (optional) one update function
• a case in the giant switch in ResourceCommand.getCollection
• (optional) a case in the giant switch in ResourceCommand.Delete

In #59518 we added a new package tool/tctl/common/resources with the Handler struct. The goal is to move all the logic handling a specific resource into its dedicated tool/tctl/common/resources/<resource-kind>.go file, create a Handler and register it in the Handlers() func in tool/tctl/common/resources/resource.go.

The wiring is already done so that any new registered handler will be used if we try to tctl get/create/udpate/delete/edit its kind.

You can find an example conversion PR here: #60300

The handler opts and signature were designed to be very similar to the existing functions, so most of the conversion is copying code around and renaming the opts variable. For some resource, their collection might be used by some other tctl commands, in this case you'll have to make a public NewXCollection() function for compatibility.

A good first resource would be types.KindInstaller because it's not a singleton, no other command uses it, and there's no weird thing like for sso connectors or tokens.

Feel free to slack me if you have questions

Appreciate the detailed response. I signed myself up for types.KindInstaller. Thanks!