Skip to content

Conversation

nklaassen
Copy link
Contributor

This PR updates the host join process in lib/service/connect.go to call the new lib/join/joinclient.Join instead of the legacy lib/auth/join.Register. This will attempt to use the new join service being implemented as part of RFD 27e where the Auth service noaw assigns the host UUID instead of allowing the joining agent to choose it. Currently only the token and bound_keypair methods are supported by the new join service, for all other join methods or when connecting to older auth servers without the new join service the implementation will fall back to joining via the legacy service.

@nklaassen nklaassen added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v18 labels Sep 30, 2025
//
// Deprecated: this function is superceded by lib/join/joinclient.Join
//
// TODO(nklaassen): DELETE IN 19.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master is v19, right?
So, according to the comment we should just delete this

However, what do you think about keeping this for at least one more release?
Or keep it behind a feature flag.

We can discuss it when actually removing it, but this seems to be a pretty important part to just remove it without keeping a way to add it back for at least one major release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theoretically as long as the new join service is fully supported by v19 then we can delete this on the client side in 19.0, but I can't delete it yet because it doesn't support all join methods yet.

But it should be fine to keep it as a fallback on the client side until 20, since v19 servers will still support it, I'll update the DELETE IN comment

@nklaassen nklaassen force-pushed the nklaassen/bots-join branch from d3ab23c to 1a2429e Compare October 1, 2025 16:00
@nklaassen nklaassen force-pushed the nklaassen/hosts-join branch from 82c2d20 to 7c4364c Compare October 1, 2025 16:00
@nklaassen nklaassen force-pushed the nklaassen/bots-join branch from 1a2429e to 2a0548a Compare October 1, 2025 17:59
@nklaassen nklaassen force-pushed the nklaassen/hosts-join branch from 7c4364c to c7925ab Compare October 1, 2025 17:59
@nklaassen nklaassen force-pushed the nklaassen/bots-join branch from 2a0548a to 29d94d0 Compare October 1, 2025 20:22
@nklaassen nklaassen force-pushed the nklaassen/hosts-join branch from c7925ab to b4b9e3e Compare October 1, 2025 20:23
@nklaassen nklaassen force-pushed the nklaassen/bots-join branch from 29d94d0 to 0606036 Compare October 8, 2025 19:31
Base automatically changed from nklaassen/bots-join to master October 10, 2025 22:50
@nklaassen nklaassen force-pushed the nklaassen/hosts-join branch from f6afd29 to 8560f7e Compare October 10, 2025 22:52
@nklaassen nklaassen enabled auto-merge October 10, 2025 22:53
@nklaassen nklaassen force-pushed the nklaassen/hosts-join branch from 7ca8f92 to 00605da Compare October 15, 2025 18:26
@nklaassen nklaassen added this pull request to the merge queue Oct 15, 2025
Merged via the queue into master with commit 652ee86 Oct 15, 2025
40 checks passed
@nklaassen nklaassen deleted the nklaassen/hosts-join branch October 15, 2025 19:08
@backport-bot-workflows
Copy link
Contributor

@nklaassen See the table below for backport results.

Branch Result
branch/v18 Create PR

nklaassen added a commit that referenced this pull request Oct 15, 2025
nklaassen added a commit that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/branch/v18 no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants