-
Notifications
You must be signed in to change notification settings - Fork 1.9k
use new join service for host joins #59778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/auth/join/join.go
Outdated
// | ||
// Deprecated: this function is superceded by lib/join/joinclient.Join | ||
// | ||
// TODO(nklaassen): DELETE IN 19.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master
is v19, right?
So, according to the comment we should just delete this
However, what do you think about keeping this for at least one more release?
Or keep it behind a feature flag.
We can discuss it when actually removing it, but this seems to be a pretty important part to just remove it without keeping a way to add it back for at least one major release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
theoretically as long as the new join service is fully supported by v19 then we can delete this on the client side in 19.0, but I can't delete it yet because it doesn't support all join methods yet.
But it should be fine to keep it as a fallback on the client side until 20, since v19 servers will still support it, I'll update the DELETE IN comment
d3ab23c
to
1a2429e
Compare
82c2d20
to
7c4364c
Compare
1a2429e
to
2a0548a
Compare
7c4364c
to
c7925ab
Compare
2a0548a
to
29d94d0
Compare
c7925ab
to
b4b9e3e
Compare
29d94d0
to
0606036
Compare
f6afd29
to
8560f7e
Compare
7ca8f92
to
00605da
Compare
@nklaassen See the table below for backport results.
|
Backport #59778 to branch/v18
Backport #59778 to branch/v18
This PR updates the host join process in lib/service/connect.go to call the new
lib/join/joinclient.Join
instead of the legacylib/auth/join.Register
. This will attempt to use the new join service being implemented as part of RFD 27e where the Auth service noaw assigns the host UUID instead of allowing the joining agent to choose it. Currently only thetoken
andbound_keypair
methods are supported by the new join service, for all other join methods or when connecting to older auth servers without the new join service the implementation will fall back to joining via the legacy service.